BS5: Update icon aliases to accurate Font Awesome 6 classes#4040
BS5: Update icon aliases to accurate Font Awesome 6 classes#4040crhallberg wants to merge 3 commits into
Conversation
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
@crhallberg, there seems to be a parse error in theme.config.php that's breaking the build.
Also, is there a reason you're removing the "FontAwesome" prefix from all of the icon configurations? This seems like it might be a problem.
Bottom line: I'm a bit concerned that this is a dangerous change to be making at the last minute. Could you clarify exactly which problem(s) it is addressing? Maybe there is a still smaller/safer fix we could make to address the issues....
|
This is absolutely not a critical fix. I realized halfway through #4031 that the FA4 icons are being shimmed by FA6, so my fears about broken icons are unfounded. If we want to skip this until icon mixins are released, there shouldn't be any issues. Icon mixins would be an excellent addition when we bring together community themes for download and customization. |
|
Thanks, @crhallberg, if you think it best to just close this and wait for #4031, that's fine with me. Sorry if this wasted some of your time! |
|
No, I definitely wasted my own time lol. |
2 participants
MVP of #4031.