Skip to content

add list element around collections-bytitle and oai-home breadcrumbs#3268

Closed
elsenhans wants to merge 1 commit into
vufind-org:devfrom
finc:pull-request-add-missing-li-for-breadcrumb
Closed

add list element around collections-bytitle and oai-home breadcrumbs#3268
elsenhans wants to merge 1 commit into
vufind-org:devfrom
finc:pull-request-add-missing-li-for-breadcrumb

Conversation

@elsenhans
Copy link
Copy Markdown
Contributor

@elsenhans elsenhans commented Dec 15, 2023

In templates collections/bytitle.phtml and oai/home.phtml are missing the <li>-elements around the breadcrumbs.
This PR is adding them.

@demiankatz demiankatz added bugfix accessibility small Minor changes to relatively few files labels Dec 15, 2023
@demiankatz demiankatz added this to the 9.1.1 milestone Dec 15, 2023
Copy link
Copy Markdown
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @elsenhans! Since this is a simple bug fix, I have backported it to the release-9.1 branch so it can be included in 9.1.1.

While I have your attention, do you mind checking in on PR #2999? I think this is your team's last open PR that's still in progress. Please let me know if I can do more to help move it forward!

@demiankatz
Copy link
Copy Markdown
Member

Merged via 02e5568.

@demiankatz demiankatz closed this Dec 15, 2023
@elsenhans
Copy link
Copy Markdown
Contributor Author

Thanks!

EreMaijala pushed a commit to EreMaijala/vufind that referenced this pull request Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility bugfix small Minor changes to relatively few files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants