Skip to content

Add translations to improve accessibility for account/list checkboxes #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
demiankatz merged 23 commits into from
Sep 11, 2023
Merged

Add translations to improve accessibility for account/list checkboxes #2982

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
5022d66
add translations to improve accessibility for checkboxes in account a…
RLangeUni Jul 7, 2023
7c501d1
Merge branch 'dev' into pull-request-select-helper-texts
demiankatz Jul 8, 2023
56a8a70
change confounded / old transloations of select_page and select_page_…
RLangeUni Jul 14, 2023
866144d
use select_page for selecting all items on page (might be confusing?)
RLangeUni Jul 14, 2023
17a12f1
normalized languages
RLangeUni Jul 14, 2023
a585412
Update en.ini
demiankatz Jul 18, 2023
871e14a
Adjust language files.
demiankatz Jul 18, 2023
828ae1f
add missing language token
elsenhans Jul 19, 2023
3c809fb
undo changes for checkbox.phtml
elsenhans Jul 20, 2023
dc0bb1c
add non generic aria-label to checkbox
elsenhans Jul 20, 2023
8c1197b
Merge branch 'dev' into pull-request-select-helper-texts
demiankatz Jul 20, 2023
3bb4467
fix translations in history and list
elsenhans Jul 20, 2023
f433f7d
add aria-label to checkouts/history.phtml
elsenhans Jul 24, 2023
96d6c06
fix order in language files
elsenhans Jul 24, 2023
8b122bf
Merge branch 'dev' into pull-request-select-helper-texts
demiankatz Sep 1, 2023
ec40b0f
Merge branch 'dev' into pull-request-select-helper-texts
demiankatz Sep 5, 2023
faf62d6
feat: wrap cart checkbox below toolbar buttons.
crhallberg Sep 8, 2023
18e3f44
feat: add ul semantics to cart buttons.
crhallberg Sep 8, 2023
7147be0
feat: wrap checkbox on search toolbar.
crhallberg Sep 8, 2023
be2f815
feat: wrap checkbox and add ul in checkouts history.
crhallberg Sep 8, 2023
6aa8540
refactor: simplify cart menu dropdown syntax
crhallberg Sep 8, 2023
bbcb32f
Merge remote-tracking branch 'origin/dev' into pull-request-select-he…
demiankatz Sep 11, 2023
cbf363b
lessToSass
demiankatz Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions languages/de.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1186,7 +1186,15 @@ See also = "Siehe auch"
see_all_ellipsis = "Alle anzeigen …"
Select this record = "Datensatz auswählen"
Select your carrier = "Wählen Sie Ihren Telefonanbieter aus"
select_all_on_page = "Alle Einträge der Seite auswählen"
select_item = "Titel für weitere Aktion auswählen"
select_item_checked_out_renew = "Titel zum Verlängern auswählen"
select_item_hold_cancel = "Titel auswählen, um Bestellung oder Vormerkung zu stornieren"
select_item_ill_request_cancel = "Titel auswählen, um Fernleihanfrage zu stornieren"
select_item_purge = "Titel zum Entfernen auswählen"
select_item_storage_retrieval_request_cancel = "Titel auswählen, um Magazinbestellung zu stornieren"
select_page = "Alles auswählen"
select_page_cart = "Alle Einträge der Zwischenablage auswählen"
select_pickup_location = "Abholort auswählen"
select_request_group = "Abholstelle auswählen"
Selected = "Ausgewählt"
Expand Down
8 changes: 8 additions & 0 deletions languages/en.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1202,7 +1202,15 @@ See also = "See also"
see_all_ellipsis = "see all…"
Select this record = "Select this record"
Select your carrier = "Select your carrier"
select_all_on_page = "Select all entries on the page"
select_item = "Select item for further action"
select_item_checked_out_renew = "Select item for renewing"
select_item_hold_cancel = "Select item for canceling holds or recalls"
select_item_ill_request_cancel = "Select item for canceling interlibrary loan requests"
select_item_purge = "Select item for purging"
select_item_storage_retrieval_request_cancel = "Select item for canceling storage retrieval requests"
select_page = "Select Page"
select_page_cart = "Select all entries in the book bag"
select_pickup_location = "Select Pick Up Location"
select_request_group = "Select Request Group"
Selected = "Selected"
Expand Down
2 changes: 1 addition & 1 deletion themes/bootstrap3/templates/cart/cart.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<div class="checkbox pull-left flip">
Comment thread
demiankatz marked this conversation as resolved.
Outdated
<label>
<input type="checkbox" name="selectAll" class="checkbox-select-all">
<?=$this->transEsc('select_page')?>
<?=$this->transEsc('select_page_cart')?>
</label>
</div>
<?php if ($this->userlist()->getMode() !== 'disabled'): ?>
Expand Down
4 changes: 2 additions & 2 deletions themes/bootstrap3/templates/checkouts/history.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
<?php if ($purgeSelectedAllowed): ?>
<label>
<input type="checkbox" name="selectAll" class="checkbox-select-all"/>
<?=$this->transEsc('select_page')?>
<?=$this->transEsc('select_all_on_page')?>
</label>
Copy link
Copy Markdown
Contributor

@crhallberg crhallberg Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the .checkbox on line 46 can be closed here instead of line... actually it may not be closed...

Copy link
Copy Markdown
Member

@demiankatz demiankatz Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checkbox div is closed, but it is wrapped around not just the checkbox but also all of the buttons. This is consistent with the markup style in holds/list.phtml, myresearch/checkedout.phtml, myresearch/illrequests.phtml and myresearch/storageretrievalrequests.phtml as well. As a result, buttons do not wrap as a group, which is inconsistent with the desired behavior we're working on elsewhere. However, because these templates have comparatively few buttons, it is less likely to cause problems in these contexts. It is probably worth making our checkbox+button markup consistent everywhere, but I think fixing this immediately is less critical.

<div class="btn-group">
<input type="submit" id="purgeSelected" name="purgeSelected" value="<?=$this->transEscAttr('loan_history_purge_selected')?>" class="btn btn-default dropdown-toggle" data-toggle="dropdown" data-lightbox-ignore>
Expand Down Expand Up @@ -82,7 +82,7 @@
<?php if (isset($ilsDetails['row_id'])): ?>
<?php $safeId = preg_replace('/[^a-zA-Z0-9]/', '', $ilsDetails['row_id']); ?>
<label>
<input class="checkbox-select-item" type="checkbox" name="purgeSelectedIDs[]" value="<?=$this->escapeHtmlAttr($ilsDetails['row_id'])?>" id="checkbox_<?=$safeId?>" />
<input class="checkbox-select-item" type="checkbox" name="purgeSelectedIDs[]" value="<?=$this->escapeHtmlAttr($ilsDetails['row_id'])?>" id="checkbox_<?=$safeId?>" aria-label="<?=$this->transEscAttr('select_item_purge')?>"/>
</label>
<?php else: ?>
<label> </label>
Expand Down
4 changes: 2 additions & 2 deletions themes/bootstrap3/templates/holds/list.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<div class="checkbox">
<label>
<input type="checkbox" name="selectAll" class="checkbox-select-all">
<?=$this->transEsc('select_page')?>
<?=$this->transEsc('select_all_on_page')?>
Comment thread
demiankatz marked this conversation as resolved.
</label>
<?php if ($this->updateForm): ?>
<div class="btn-group">
Expand Down Expand Up @@ -70,7 +70,7 @@
<?php endif; ?>
<div class="checkbox">
<label>
<input type="checkbox" name="selectedIDS[]" value="<?=$this->escapeHtmlAttr($ilsDetails['cancel_details'] ?? $ilsDetails['updateDetails']) ?>" id="checkbox_<?=$safeId?>" class="checkbox-select-item">
<input type="checkbox" name="selectedIDS[]" value="<?=$this->escapeHtmlAttr($ilsDetails['cancel_details'] ?? $ilsDetails['updateDetails']) ?>" id="checkbox_<?=$safeId?>" class="checkbox-select-item" aria-label="<?=$this->transEscAttr('select_item_hold_cancel')?>">
Comment thread
demiankatz marked this conversation as resolved.
</label>
</div>
<?php elseif ($this->cancelForm || $this->updateForm): ?>
Expand Down
2 changes: 1 addition & 1 deletion themes/bootstrap3/templates/myresearch/bulk-action-buttons.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<nav class="bulkActionButtons">
Comment thread
demiankatz marked this conversation as resolved.
<div class="bulk-checkbox">
<input type="checkbox" name="selectAll" class="checkbox-select-all" id="myresearchCheckAll">
<label for="myresearchCheckAll"><?=$this->transEsc('select_page')?></label>
<label for="myresearchCheckAll"><?=$this->transEsc('select_all_on_page')?></label>
</div>
<ul class="action-toolbar">
<li><button class="toolbar-btn" type="submit" name="email" value="1" title="<?=$this->transEscAttr('email_selected')?>"><?=$this->icon('send-email') ?> <?=$this->transEsc('Email') ?></button>
Expand Down
4 changes: 2 additions & 2 deletions themes/bootstrap3/templates/myresearch/checkedout.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
<div class="checkbox">
<label>
<input type="checkbox" name="selectAll" class="checkbox-select-all">
<?=$this->transEsc('select_page')?>
<?=$this->transEsc('select_all_on_page')?>
</label>
<div class="btn-group">
<input type="submit" id="renewSelected" name="renewSelected" value="<?=$this->transEscAttr('renew_selected')?>" class="btn btn-default dropdown-toggle" data-toggle="dropdown" data-lightbox-ignore>
Expand Down Expand Up @@ -100,7 +100,7 @@
<?php if (isset($ilsDetails['renewable']) && $ilsDetails['renewable'] && isset($ilsDetails['renew_details'])): ?>
<?php $safeId = preg_replace('/[^a-zA-Z0-9]/', '', $ilsDetails['renew_details']); ?>
<label>
<input class="checkbox-select-item" type="checkbox" name="renewSelectedIDS[]" value="<?=$this->escapeHtmlAttr($ilsDetails['renew_details'])?>" id="checkbox_<?=$safeId?>">
<input class="checkbox-select-item" type="checkbox" name="renewSelectedIDS[]" value="<?=$this->escapeHtmlAttr($ilsDetails['renew_details'])?>" id="checkbox_<?=$safeId?>" aria-label="<?=$this->transEscAttr('select_item_checked_out_renew')?>">
</label>
<input type="hidden" name="selectAllIDS[]" value="<?=$this->escapeHtmlAttr($ilsDetails['renew_details'])?>">
<input type="hidden" name="renewAllIDS[]" value="<?=$this->escapeHtmlAttr($ilsDetails['renew_details'])?>">
Expand Down
2 changes: 1 addition & 1 deletion themes/bootstrap3/templates/myresearch/storageretrievalrequests.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
<div class="checkbox">
<input type="hidden" name="cancelAllIDS[]" value="<?=$this->escapeHtmlAttr($ilsDetails['cancel_details']) ?>">
<label class="pull-left flip">
<input type="checkbox" name="cancelSelectedIDS[]" value="<?=$this->escapeHtmlAttr($ilsDetails['cancel_details']) ?>" id="checkbox_<?=$safeId?>">
<input type="checkbox" name="cancelSelectedIDS[]" value="<?=$this->escapeHtmlAttr($ilsDetails['cancel_details']) ?>" id="checkbox_<?=$safeId?>" aria-label="<?=$this->transEscAttr('select_item_storage_retrieval_request_cancel')?>">
</label>
</div>
<?php endif; ?>
Expand Down
2 changes: 1 addition & 1 deletion themes/bootstrap3/templates/record/checkbox.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<label class="record-checkbox hidden-print">
<input class="checkbox-select-item" type="checkbox" name="ids[]" value="<?=$this->escapeHtmlAttr($this->id) ?>"<?php if (isset($this->formAttr)): ?> form="<?=$this->formAttr ?>"<?php endif; ?>>
<input class="checkbox-select-item" type="checkbox" name="ids[]" value="<?=$this->escapeHtmlAttr($this->id) ?>"<?php if (isset($this->formAttr)): ?> form="<?=$this->formAttr ?>"<?php endif; ?> aria-label="<?=$this->transEscAttr('select_item')?>">
<span class="checkbox-icon"></span>
<?php if (strlen($this->number ?? '') > 0): ?><span class="sr-only"><?=$this->transEsc('result_checkbox_label', ['%%number%%' => $this->number]) ?></span><?php endif; ?>
</label>
Expand Down
2 changes: 1 addition & 1 deletion themes/bootstrap3/templates/search/bulk-action-buttons.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<nav class="bulkActionButtons">
<div class="bulk-checkbox">
<input type="checkbox" class="checkbox-select-all" name="selectAll" id="<?=$this->idPrefix?>addFormCheckboxSelectAll"<?php if ($this->formAttr): ?> form="<?=$this->escapeHtmlAttr($this->formAttr) ?>"<?php endif; ?>>
<label for="<?=$this->idPrefix?>addFormCheckboxSelectAll"><?=$this->transEsc('select_page')?></label>
<label for="<?=$this->idPrefix?>addFormCheckboxSelectAll"><?=$this->transEsc('select_all_on_page')?></label>
</div>
<ul class="action-toolbar">
<?php if (isset($this->showBulkOptions) && $this->showBulkOptions): ?>
Expand Down