Remove confusing with_selected string.#2978
Merged
Merged
Conversation
1 task
crhallberg
approved these changes
Jul 6, 2023
bpalme
pushed a commit
to bpalme/vufind
that referenced
this pull request
Aug 5, 2023
EreMaijala
pushed a commit
to EreMaijala/vufind
that referenced
this pull request
Aug 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on #2874, the "with selected" string in our button bars (search results / favorites) was unhelpful and also misleading due to the way it was incorporated into the wrong label tag. It was also inconsistent with some other parts of the interface (e.g. the book bag) which had similar interfaces without the "with selected" part. This PR simply removes the string, as it no longer seems to be needed based on analysis of web trends.
BEFORE:
AFTER:
TODO