Repository navigation
IBKR: don't double count transfers reported as Transfer and TransferLot - #441
Merged
Merged
Conversation
When a Flex query has both the "Transfer" and "Lot" options selected, IBKR reports each transfer as a Transfer and again split into TransferLot entries. ibflex puts both into stmt.Transfers, so the quantity was counted twice, leading to a confusing negative balance error. Skip TransferLot entries that are covered by a Transfer for the same conid and date. Fixes #440 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016RuX6myhTcq7NRKnWuD1h6
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📄 Sample PDF and XML PreviewA sample Steuerauszug has been generated from (Artifact expires in 14 days. Requires GitHub login to download. View workflow run) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #440
Problem
When a Flex query has both the "Transfer" and "Lot" options selected under Transfers, IBKR reports each transfer once as a
<Transfer>and again split up into<TransferLot>entries. ibflex puts both intostmt.Transfers, so the importer added the transferred quantity twice. This led to a confusing "negative balance" error.Fix
As suggested in the issue discussion, the
Transferentry is treated as authoritative. ATransferLotis skipped when aTransferexists for the sameconidand date. A query that only has "Lot" selected is handled as before: TransferLots without a matching Transfer are still processed.Changes
ibkr_importer.py: collect the(conid, date)keys ofTransferentries and skipTransferLotentries that match one.docs/importer_ibkr.md: added a note that selecting both options is fine.Testing
pytest tests/: 915 passed, 6 skippedGenerated by Claude Code