Skip to content

Fix weird malformed license notice in test file#8395

Merged
AdamGS merged 1 commit into
developfrom
adamg/fix-license-header-for-file
Jun 12, 2026
Merged

Fix weird malformed license notice in test file#8395
AdamGS merged 1 commit into
developfrom
adamg/fix-license-header-for-file

Conversation

@AdamGS

@AdamGS AdamGS commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

I was trying hawkeye which has some nice features reuse doesn't have, and it found this weird issue.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS requested a review from a team June 12, 2026 19:07
@AdamGS AdamGS added the changelog/skip Do not list PR in the changelog label Jun 12, 2026
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: Apache-2.0
// SPDX-FileCopyrightText: Copyright the Vortex contributorsuse crate::dtype::Nullability;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, but think we need to contact Vortex contributorsuse crate::dtype::Nullability; and ask for their permission before we change the license

@AdamGS AdamGS enabled auto-merge (squash) June 12, 2026 19:10
@AdamGS AdamGS merged commit 5580295 into develop Jun 12, 2026
77 of 79 checks passed
@AdamGS AdamGS deleted the adamg/fix-license-header-for-file branch June 12, 2026 19:13
@codspeed-hq

codspeed-hq Bot commented Jun 12, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 24.05%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 107 improved benchmarks
❌ 6 regressed benchmarks
✅ 1415 untouched benchmarks
⏩ 10 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation compare[12] 115.9 µs 136.4 µs -15.05%
Simulation varbinview_large 112.9 µs 131.5 µs -14.17%
Simulation decompress_rd[f64, (100000, 0.01)] 845.9 µs 981.6 µs -13.83%
Simulation decompress_rd[f64, (100000, 0.1)] 845.9 µs 981.6 µs -13.82%
Simulation compare[8] 105 µs 118 µs -11.04%
Simulation compare[10] 135.9 µs 152.7 µs -11.02%
Simulation compare[48] 300.7 µs 213 µs +41.16%
Simulation compare[50] 319.2 µs 227.7 µs +40.18%
Simulation compare[49] 317.7 µs 228.2 µs +39.26%
Simulation compare[44] 287.8 µs 207.5 µs +38.7%
Simulation compare[46] 302.5 µs 218.5 µs +38.46%
Simulation compare[47] 309.4 µs 223.5 µs +38.42%
Simulation compare[40] 263.5 µs 190.7 µs +38.19%
Simulation compare[44] 292.4 µs 212.1 µs +37.84%
Simulation compare[45] 301 µs 218.9 µs +37.51%
Simulation compare[43] 287.7 µs 209.2 µs +37.48%
Simulation compare[42] 281.1 µs 204.5 µs +37.43%
Simulation compare[40] 268.4 µs 195.6 µs +37.18%
Simulation compare[43] 292.6 µs 214.2 µs +36.59%
Simulation compare[42] 286 µs 209.4 µs +36.56%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/fix-license-header-for-file (3d07906) with develop (31167ca)

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants