Skip to content

Timeout slow tests#8388

Merged
AdamGS merged 2 commits into
developfrom
adamg/timeout-slow-tests
Jun 12, 2026
Merged

Timeout slow tests#8388
AdamGS merged 2 commits into
developfrom
adamg/timeout-slow-tests

Conversation

@AdamGS

@AdamGS AdamGS commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

It seems like the rate of tests hanging has gone up significantly recently which is very wasteful. This config marks tests as slow at 30s, and times them out after 3 periods (AKA 90 seconds).

As far as I'm aware there's only 1 test that approaches 1 minute (also raised its priority), so this change should timeout any normal run.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS requested review from a team and joseph-isaacs June 12, 2026 10:55
Comment thread .config/nextest.toml Outdated
Co-authored-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the adamg/timeout-slow-tests branch from b6ff247 to 5471807 Compare June 12, 2026 11:02
@codspeed-hq

codspeed-hq Bot commented Jun 12, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 12.28%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 3 improved benchmarks
✅ 1523 untouched benchmarks
⏩ 10 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation encode_varbin[(1000, 32)] 167.2 µs 148.4 µs +12.67%
Simulation encode_varbin[(1000, 8)] 160.8 µs 143.5 µs +12.09%
Simulation encode_varbin[(1000, 4)] 160 µs 142.7 µs +12.08%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/timeout-slow-tests (5471807) with develop (c7e0d17)

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@AdamGS AdamGS merged commit d70c77e into develop Jun 12, 2026
65 of 66 checks passed
@AdamGS AdamGS deleted the adamg/timeout-slow-tests branch June 12, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants