Skip to content

Build tests before running tests under sanitizer#8385

Merged
AdamGS merged 1 commit into
developfrom
adamg/sanitizar-build-tests
Jun 12, 2026
Merged

Build tests before running tests under sanitizer#8385
AdamGS merged 1 commit into
developfrom
adamg/sanitizar-build-tests

Conversation

@AdamGS

@AdamGS AdamGS commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

We currently have a build step before sanitizier runs, but we don't actually build the tests in that step, so this PR adds that. The changes these tests build times from 1:37 + 2:44 to 2:49, so about 90 seconds of savings for flows that seem to take around 7-8 minutes.

@AdamGS AdamGS requested review from a team, 0ax1 and myrrc June 12, 2026 07:58
@codspeed-hq

codspeed-hq Bot commented Jun 12, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 11.33%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 2 improved benchmarks
❌ 6 regressed benchmarks
✅ 1518 untouched benchmarks
⏩ 10 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 20.4 µs 35.4 µs -42.42%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 176.8 µs 212.9 µs -16.98%
Simulation chunked_varbinview_canonical_into[(100, 100)] 272.7 µs 307.9 µs -11.41%
Simulation encode_varbin[(1000, 4)] 142.9 µs 159.9 µs -10.61%
Simulation encode_varbin[(1000, 8)] 143.6 µs 160.6 µs -10.61%
Simulation encode_varbin[(1000, 32)] 148.5 µs 165.2 µs -10.09%
Simulation bitwise_not_vortex_buffer_mut[128] 244.4 ns 215.3 ns +13.55%
Simulation bitwise_not_vortex_buffer_mut[1024] 304.7 ns 275.6 ns +10.58%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/sanitizar-build-tests (60aee9d) with develop (c6a0b7b)

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the adamg/sanitizar-build-tests branch from 6b72627 to 60aee9d Compare June 12, 2026 08:24
@AdamGS AdamGS merged commit 50bee6e into develop Jun 12, 2026
67 of 69 checks passed
@AdamGS AdamGS deleted the adamg/sanitizar-build-tests branch June 12, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants