Creation of the Shutdown Plugin#1967
Creation of the Shutdown Plugin#1967Frascott05 wants to merge 8 commits intovolatilityfoundation:developfrom
Conversation
|
Hey @Frascott05 - nice! I've tested it on a few samples and it seems to work. The old vol plugin would find the current control set itself or default to 1 https://github.com/volatilityfoundation/volatility/blob/328a178edeecaf8d2abf96618ecfcb14a7b0c860/volatility/plugins/registry/shutdown.py#L60-L63 It looks like your method will try them all from 1-5? I don't know much about windows, is 5 the maximum? It would be nice to explain why the magic number 5 was chosen in the code, just in case something changes in the future. There is also a handy function used in lots of plugins to convert the filetime in wintime_to_datetime, so you shouldn't need to write you own filetime_to_dt. (I've attempted to use the suggestions feature of the first time to explain what I mean... hopefully it makes sense) If you can it would be really helpful to write a test for this plugin too, that way it can automatically checked in the future. |
Co-authored-by: Eve <120014766+eve-mem@users.noreply.github.com>
Co-authored-by: Eve <120014766+eve-mem@users.noreply.github.com>
Co-authored-by: Eve <120014766+eve-mem@users.noreply.github.com>
|
Hi @eve-mem, Despite the old shutdown plugin was able to find the current control set itself or default to 1, |
Add comments to explain why we search for 5 registry sets
|
Also, do you have any suggestions or examples to follow for writing a test? |
|
If you look at Here's an example: volatility3/test/plugins/windows/windows.py Lines 214 to 235 in fc8edc4 There are two different windows samples at the moment to test with: Lines 13 to 17 in fc8edc4 So you could write a test that runs your plugins against both samples and asserts that the output is as expected. I hope that helps. |
|
sorry, I could't do it today, I hope I'll be able to work on the test case tomorrow |
|
Don't worry, it can take weeks and months to get pull request reviewed and checked. There's no rush. |
|
I've added the test class that checks for the right output of the plugin, thank you for the help |
I added the Shutdown plugin from volatility2 that could be useful for some digital forensic analysis.
Hope this can be added to the official repo.