Skip to content

Attempt to fix the local filepath not being detected correctly #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ikelos wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Attempt to fix the local filepath not being detected correctly #1959

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cf35b9
Attempt to fix the local filepath not being detected correctly
ikelos Mar 10, 2026
02af9f9
Add in more checks and better error handling
ikelos Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 25 additions & 17 deletions volatility3/framework/automagic/symbol_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import json
import logging
import os
import pathlib
import sqlite3
import urllib
import urllib.parse
Expand Down Expand Up @@ -239,16 +240,19 @@ def find_location(
results = self._database.cursor().execute(statement, parameters).fetchall()
result = None
for row in results:
local_filepath = self._get_local_filepath(row["location"])
if not (
local_filepath is None
or local_filepath.startswith(tuple(constants.SYMBOL_BASEPATHS))
):
vollog.debug(
f"Location {row['location']} found but outside of the registered symbol paths"
)
else:
result = row["location"]
if row["location"]:
local_filepath = pathlib.Path(self._get_local_filepath(row["location"]))
if local_filepath and not any(
[
local_filepath.is_relative_to(basepath)
for basepath in constants.SYMBOL_BASEPATHS
]
):
vollog.debug(
f"Location {row['location']} found but outside of the registered symbol paths"
)
else:
result = row["location"]
return result

def get_local_locations(self) -> Generator[str, None, None]:
Expand Down Expand Up @@ -495,13 +499,17 @@ def get_identifier_dictionary(
vollog.debug(
f"Duplicate entry for identifier {row['identifier']}: {row['location']} and {output[row['identifier']]}"
)
local_filepath = self._get_local_filepath(row["location"])
if local_filepath and not local_filepath.startswith(
tuple(constants.SYMBOL_BASEPATHS)
):
vollog.debug(
f"Location {row['location']} was not in the registered symbol paths and therefore not in the identifier dictionary"
)
if row["location"]:
local_filepath = pathlib.Path(self._get_local_filepath(row["location"]))
if local_filepath and not any(
[
local_filepath.is_relative_to(basepath)
for basepath in constants.SYMBOL_BASEPATHS
]
):
vollog.debug(
f"Location {row['location']} was not in the registered symbol paths and therefore not in the identifier dictionary"
)
else:
output[row["identifier"]] = row["location"]
return output
Expand Down
Loading