[ROCm] Fix MiniMax-M3 EAGLE draft backend recipe - #740
Open
tuukkjs wants to merge 1 commit into
Open
Conversation
Use the validated Triton attention backend for AMD EAGLE draft configs while keeping CUDA defaults on FlashAttention. Signed-off-by: Tuukka Sarvi <tuukka.sarvi@amd.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds AMD hardware overrides for the eagle3 and eagle3_gqa speculative decoding configurations in models/MiniMaxAI/MiniMax-M3.yaml, switching the attention backend from FLASH_ATTN to TRITON_ATTN. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix MiniMax-M3 ROCm EAGLE draft attention backend recipe.
Update the MiniMax-M3 recipe so AMD ROCm EAGLE3 speculative decoding uses
TRITON_ATTNfor the draft model attention backend. Keep the default CUDA/NVIDIA EAGLE3 draft backend asFLASH_ATTN.AI assistance was used for this PR.
Motivation
The MI355X MiniMax-M3 MXFP8 recipe already selects
TRITON_ATTNfor the target model on ROCm, but the EAGLE3speculative_configstill selectedFLASH_ATTNfor the draft model:vllm serve MiniMaxAI/MiniMax-M3-MXFP8 \ --block-size 128 \ --attention-backend TRITON_ATTN \ --tensor-parallel-size 8 \ --tool-call-parser minimax_m3 \ --enable-auto-tool-choice \ --reasoning-parser minimax_m3 \ --speculative-config '{"method": "eagle3", "model": "Inferact/MiniMax-M3-EAGLE3", "num_speculative_tokens": 3, "attention_backend": "FLASH_ATTN"}'On ROCm, that draft backend selection failed during EAGLE/drafter startup:
Using
TRITON_ATTNfor the EAGLE draft backend allowed the same ROCm setup to start successfully:vllm serve MiniMaxAI/MiniMax-M3-MXFP8 \ --block-size 128 \ --attention-backend TRITON_ATTN \ --tensor-parallel-size 8 \ --tool-call-parser minimax_m3 \ --enable-auto-tool-choice \ --reasoning-parser minimax_m3 \ --speculative-config '{"method": "eagle3", "model": "Inferact/MiniMax-M3-EAGLE3", "num_speculative_tokens": 3, "attention_backend": "TRITON_ATTN"}'Validation
vllm/vllm-openai-rocm:nightly-cb8104839c141609d99f1254459ef3a4f1bd4263Result:
speculative_confignow usesTRITON_ATTN.speculative_configstill usesFLASH_ATTN.