Skip to content

Pin Python dependencies in requirements.txt - #675

Open
arijitroy003 wants to merge 1 commit into
vllm-project:mainfrom
arijitroy003:fix/pin-deps
Open

Pin Python dependencies in requirements.txt#675
arijitroy003 wants to merge 1 commit into
vllm-project:mainfrom
arijitroy003:fix/pin-deps

Conversation

@arijitroy003

Copy link
Copy Markdown

Summary

Pins Python dependency versions in requirements.txt for reproducible builds.

Changes

  • Pin mkdocs to 1.6.1
  • Pin mkdocs-api-autonav to 0.4.0
  • Pin mkdocs-material to 9.7.7
  • Pin mkdocs-awesome-nav to 3.3.0
  • Pin mkdocs-glightbox to 0.5.2
  • Pin python-markdown-math to 0.9
  • Pin mkdocs-same-dir to 0.1.5
  • Pin mkdocs-git-revision-date-localized-plugin to 1.5.3

Testing

Verified by grep that all dependencies are now pinned with == specifiers.

Signed-off-by: arijitroy003 <arijitroy003@gmail.com>
@vercel

vercel Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vllm-recipes Error Error Jul 23, 2026 3:00pm

Request Review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request pins the versions of several mkdocs and related documentation dependencies in requirements.txt to ensure reproducible builds. The reviewer pointed out that the requirements.txt file is missing a trailing newline, which should be added to comply with POSIX standards and prevent future diff issues.

Comment thread requirements.txt
mkdocs-glightbox==0.5.2
python-markdown-math==0.9
mkdocs-same-dir==0.1.5
mkdocs-git-revision-date-localized-plugin==1.5.3 No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The requirements.txt file is missing a newline at the end of the file. According to POSIX standards, files should end with a newline character to ensure compatibility with various command-line tools and to prevent future diffs from showing unnecessary changes when new dependencies are added.

mkdocs-git-revision-date-localized-plugin==1.5.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant