Add DSv4 Flash recipe for DGX Station - #669
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2e8179f to
45afefb
Compare
There was a problem hiding this comment.
Code Review
This pull request introduces support for per-hardware default strategy recommendations (via default_strategy_hardware) and applies it to the DeepSeek-V4-Flash model on the DGX Station GB300 hardware. It also updates the DGX Station single-GPU serving guide with optimized vLLM parameters. A critical shadowing bug was identified in the review where the exact-GPU-ID overrides (such as dgx_station_gb300) are overwritten by generation-level overrides (blackwell) due to the evaluation order in command synthesis.
|
@esmeetu , can you review this one? |
|
The configs looks good, e.g. moe backend = auto.
|
If we don't change the default recipe, then it will be broken on DGX Station. I don't think that will be a good experience. We need at least a functional recipe at the top level and more optimization can be added in the markdown section
Yes, this tells coding agents about new fields/features which are added. |
Also add a per hardware default strategy for overriding the overall default strategy Signed-off-by: Prerit Rodney <240578995+prodney-dev@users.noreply.github.com>
45afefb to
73187a3
Compare
|
It could be simple if just use and don't need touch js code: TP should use auto moe backend instead of |
The idea of |
|
@esmeetu, let me know if you have any more concerns or we can merge this PR? |
|
@prodney-dev Can we make default strategy to |
@esmeetu, I can change that but I haven't verified on other hardware. If it is okay, I can make the change. |
Also add a per hardware default strategy for overriding the overall default strategy