Skip to content

chore(ui): use upstream rrweb-snapshot hackCssPseudoClasses instead of local patch #10693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hi-ogawa wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(ui): use upstream rrweb-snapshot hackCssPseudoClasses instead of local patch #10693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/ui/client/components/trace/TraceView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ watch([selectedStep, iframeEl], ([step, iframe]) => {
cache: createCache(),
mirror,
UNSAFE_allowUnprotectedRebuild: true,
// opt into mirroring the user-action pseudo-classes we track, so their
// snapshot-time styles paint (rrweb-io/rrweb#1896, replaces our local patch)
hackCssPseudoClasses: Object.keys(pseudoClassIds) as any,
})
for (const [className, ids] of Object.entries(pseudoClassIds)) {
for (const id of ids) {
Expand Down
23 changes: 0 additions & 23 deletions patches/rrweb-snapshot@2.0.1.patch
View file
Open in desktop

This file was deleted.

17 changes: 9 additions & 8 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,14 @@
rollup: 'catalog:'
vite: 'catalog:'
vitest: workspace:*
# local tarball of rrweb-snapshot built from rrweb-io/rrweb#1896 (hackCssPseudoClasses)
rrweb-snapshot: file:./rrweb-snapshot-2.1.0.tgz

Check failure on line 41 in pnpm-workspace.yaml

View workflow job for this annotation

GitHub Actions / Lint: node-latest, ubuntu-latest 

Expected mapping keys to be in ascending order. 'rrweb-snapshot' should be before 'vite'
patchedDependencies:
'@sinonjs/fake-timers@15.4.0': patches/@sinonjs__fake-timers@15.4.0.patch
acorn@8.11.3: patches/acorn@8.11.3.patch
cac@6.7.14: patches/cac@6.7.14.patch
istanbul-lib-instrument: patches/istanbul-lib-instrument.patch
istanbul-lib-source-maps: patches/istanbul-lib-source-maps.patch
rrweb-snapshot@2.0.1: patches/rrweb-snapshot@2.0.1.patch
catalog:
'@babel/core': ^7.29.0
'@babel/plugin-proposal-decorators': ^7.29.0
Expand Down
Binary file added rrweb-snapshot-2.1.0.tgz
View file
Open in desktop
Binary file not shown.
Loading