-
Notifications
You must be signed in to change notification settings - Fork 40
Debugger records all old heaps and their parent heaps #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jackstodart
wants to merge
22
commits into
viperproject:master
Choose a base branch
from
jackstodart:reworking_debugger
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
93d0c2f
improve debugger display and fix evalInOld bug
jackstodart f0bf99c
starting to add heap parents
jackstodart 28049b4
Merge remote-tracking branch 'origin/reworking_debugger' into reworki…
jackstodart 9a46009
added recordOldHeap function to Verifier and finished reworking old h…
jackstodart 5566c8e
removing warnings, etc
jackstodart d2ff327
added missing recordOldHeap for method calls
jackstodart 9c89c1e
fixed recordOldHeap in Applying case and changed how we record branch…
jackstodart 9a71d36
fixed recording wrong old branch conditions
jackstodart 09a32c7
Merge branch 'master' into reworking_debugger
jackstodart ee9a05c
separated old heaps from debug heaps, now records partial produce/con…
jackstodart cc256f8
Merge remote-tracking branch 'origin/reworking_debugger' into reworki…
jackstodart 3b5115a
corrected recording heaps in consumeTlc
jackstodart 2245b0e
re-re-reworked to only record intermediate heaps as required during i…
jackstodart 4382632
Merge branch 'master' into reworking_debugger
jackstodart b7be739
fixed wrong recording of final heaps after unfold inhale etc
jackstodart 7d8ddbf
Merge branch 'master' into reworking_debugger
jackstodart 5098e76
fixed bug in merge for intermediateHeapCause
jackstodart f3fad40
fixed some heaps not recorded before unfolding etc, replaced old reco…
jackstodart 48253a4
fixed heap equality by values, don't replace heaps for new labels
jackstodart 359c8f6
fixed all sorts of nonsense
jackstodart cb912d8
record heaps in loops, but heaps after loops not recorded yet
jackstodart 03ff629
corrected loop recording, please be finished now
jackstodart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this now assumes that the heap in which we're evaluating the field access has already been recorded, right? But I don't think that's necessarily the case, because of the scenario we I think briefly talked about but then got interrupted (or if there was some conclusion I don't remember it):
x.fis evaluated in a heap that is neither h1 nor h2, but an intermediate one that is h1 + thex.fpermission. So I think here you'd get a new debug label that doesn't correspond to an existing heap, but the new heap is also not recorded.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I think this is finally fixed and now we record intermediate heaps when they are used (with either funcapp or field access).