Infer bounded type for untyped int literals in comparisons#1016
Closed
jcp19 wants to merge 1 commit into
Closed
Conversation
An untyped integer constant appearing as one operand of a comparison (==, !=, <, <=, >, >=, including ghost equality/inequality) now takes its context type from the other operand when that operand has a bounded integer type. This mirrors Go's implicit conversion of untyped constants in comparisons, so the desugarer and encoding never see mixed-sort operands like Int vs int8. Implemented by extending getTypeFromCtxt in ExprTyping with cases for the comparison AST nodes, delegating to a new boundedCtxFromComparison helper that resolves the other operand's type, unwraps any named wrappers via underlyingType, and returns the operand's declared type when its kind is a BoundedIntegerKind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opened by mistake in a claude code session