test: handle missing peer addrbind - #28
Conversation
✅ No Merge Conflicts DetectedThis PR currently has no conflicts with other open PRs. |
|
The linux64_tsan-test failure is unrelated to this PR and matches the known p2p_blocksonly.py TSAN flake tracked in dashpay#7436. All three attempts timed out at second_peer.wait_for_tx(txid) after 240 seconds, with no ThreadSanitizer report. This PR only changes the TestNode peer metadata lookup from peer["addrbind"] to peer.get("addrbind"); behavior is unchanged when addrbind is present, and the change does not affect transaction relay. The same test passed locally on current upstream/develop. The PR is proper as-is. No branch change, history rewrite, empty commit, push, or CI retrigger is needed for this unrelated failure. |
|
@vijaydasmp This remains blocked only by the July 10 |
|
@vijaydasmp Nine-day follow-up: head |
Fixes the unresolved CodeRabbit finding forwarded from dashpay#7124.
getpeerinfodocumentsaddrbindas optional, so usepeer.get("addrbind")while preserving the existing exact(addr, addrbind)match and uniqueness assertion.Validation:
python3 -m py_compile test/functional/test_framework/test_node.pygit diff --checkffe93588fe819e2fddf7d2f26598d6d54aee3ba3: PASS, zero findingsOriginal thread: dashpay#7124 (comment)