Repository navigation
Conversation
CI pinned Node 22.12.0 while .ddev/config.yaml provisions 24.13.0, so CI built the theme on a toolchain no developer uses. 22.12.0 also ships npm 10.9, which is below the theme's own engines.npm >=11.0.0 - npm does not enforce engines by default, so that went unnoticed. .nvmrc now holds 24.13.0, matching DDEV, and both workflows read it. Prompted by viget-blocks-toolkit's v1.1.9 release build failing because its ci.yaml and release.yaml had drifted onto different Node versions and npm 10 cannot install an npm 11 lock. Verified npm ci in the theme on node:24.13.0-slim - exit 0, npm 11.6.2. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DR1cWHgptENsJa7GTrmtQ3
matthisamoto
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI pinned Node
22.12.0while.ddev/config.yamlprovisions24.13.0. So CI built the theme on a toolchain no developer actually uses.Worse: 22.12.0 ships npm 10.9, and the theme's own
package.jsondeclares"engines": { "npm": ">=11.0.0" }. npm doesn't enforceengineswithoutengine-strict, so CI has been quietly building below the theme's declared floor..nvmrcnow holds24.13.0to match DDEV, andbuild.yamlanddeploy.yamlboth read it.Why now
viget-blocks-toolkit's v1.1.9 release build failed at
npm ciwith 41Missing ... from lock fileerrors - itsci.yamlhad moved to Node 24 and itsrelease.yamlhadn't, and npm 10 can't install an npm 11 lock. CI was green; the break only appeared on the tag push.Same class of problem here, one step earlier: nothing has broken yet because CI's npm 10.9 can still read the committed lock. It stops being able to the moment someone runs
npm installin DDEV (npm 11) and commits the result - which is the normal workflow.The fix that matters isn't the version number, it's having one source so CI, DDEV and the release path can't disagree.
Same pass in the plugin repos: viget-blocks-toolkit#40, viget-post-type-taxonomy-sync#17, mega-menu-block#27.
Verified
npm ciinwp-content/themes/wp-starteronnode:24.13.0-slim- exit 0, npm 11.6.2, no missing lock entries.Note
No changelog entry here - CI only, no runtime change. If you'd rather it appear in 1.1.0, it's a one-liner to fold into #266's
## v1.1.0section, and doing it there avoids the two PRs conflicting onCHANGELOG.md.Issues
Testing Instructions
ddev startstill works, since.nvmrcmatches what DDEV already provisions.