Repository navigation
mem: the compact rules read call directly, not a renamed copy of it - #72
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compact rules of
--memread a relationscall, whichMem.sFactsfilled with a renamed copy of everycallfact: 10,402 extra input facts on s2c. The rules now readcallitself, andMem.SCallRis gone.Measured on s2c compiling itself, both compilers on the same input (
perf stat -e instructions:u, twice each):--memChecks:
--memon s2c is byte-identical, and the C, stderr and exit code of 830 outputs (prog, cok, cneg, neg, self) are identical.Mutants (call args swapped in one rule; each builds):
need(F) :- call(F, G), unb(G)runSink(F) :- call(F, G), runSink(G)unb(F) :- call(F, G), unb(G)C.deepat line 52)The third mutant survived the old tests (the gap was there with
scalltoo): no test had a def that is unbounded only through a callee two calls down.C.deepcallsC.count, which calls the unboundedCL.build; it is a compact candidate only when unbounded goes up the call chain.Also measured and not landed: grouping the Mem facts by relation (an SMap group-by) before the solve, so that
D.loadgets long runs, made--mem1.2% slower: the group-by costs more than the runs save.