Repository navigation
Conversation
…r core) Component, prog, neg, cneg, cok and l2-agree tests are each a fn of the test file. par runs them GATE_JOBS at once and prints each test's verdict in file order, so the log reads as a serial run's. A test process that exits nonzero or dies is a FAIL line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gate was slow because every test loop ran one test at a time. Most of the time goes to the 22 component tests: each one is a C compile of all of s2, about 3 s and 157 MB. After them come 126 prog tests and about 290 neg, cneg and cok tests.
Now each loop body is a function of the test file (
t_comp,t_prog,t_neg,t_cneg,t_cok,t_l2), andparruns them withxargs -0 -n2 -P "$GATE_JOBS".GATE_JOBSdefaults tonproc. Each test writes its verdict to its own file, andparprints the files in file order, so the log reads like the serial run. GNU parallel is not installed, so xargs adds no dependency.FAIL detection:
parreturn 1, and the caller setsfailparaddsFAIL <fn>: a test process diedI checked this with fake test functions: output order kept, a FAIL line gives rc=1, and a
kill -9gives the "died" line and rc=1.Not done: the serial bootstrap (s2c0, then s2c1, then the fixpoint, about 39 s) stays serial, because each step needs the one before. The eval, hash, mem and store loops are small, so they stay serial too.
Not yet verified: my comparison run (serial
run.shfrom main, then this one, on the same tree, with logs to be byte-identical and both timed) is still running. I will post the result here. CI decides the rest.