Repository navigation
effects: rt_* only in Srs.* handlers; tests use requests (E2b + E3 part 2) - #38
Merged
Merged
Conversation
…]); tests and libs use effect requests (E3 part 2): Console.*, Str.*, Srs.Arena/Srs.Heap, stateless test handlers, test externs ext_same/ext_handle; a capability whose name an inner local shadows is not the innermost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E2b + E3 part 2 of the effects epic.
rt_*is now legal only in the body of aSrs.*handler; the tests and libs use effect requests.error[rt-outside-srs]:Ty.Modeis nowRun(by: User | Srs)orComptime. A handler namedSrs.*runs asSrs. A call of anrt_*extern anywhere else, spec bodies included, is the error.ArenaandHeapare renamedSrs.ArenaandSrs.Heap. Emit keys its inline bump allocator onSrs.Arena(vt_Srs__Arena).rt_print*andrt_str_*calls becomeConsole.*andStr.*. Eachmainthat prints openshandle io = Srs.Console(). The test handlers use the stateless shape. The test-only externsrt_sameandrt_handleare renamedext_sameandext_handle.parse.outis updated: it prints the migratedcontracts.srs.valshadows is skipped. Before, the C referred to theval. Bead vic-mgd4 tracks the same question in Flow.Tests:
neg/eff_rtandprog/eff_shadow.neg/spec_externkeepsrt_print. It now reports bothimpure-callandrt-outside-srs.Bootstrap: two rounds to the fixpoint (n2 == n3). The seed is the new compiler's own C.
Local gate: 199 ok and 2 FAIL, both load timeouts on a busy host.
s2c_parsepasses when rerun alone.s2c_typescompiles in 3.4 s under load 8 (limit 5 s) and its output matches.Mutants: 3 of 3 killed.
prog/eff_shadowgetsno-op add.neg/eff_rtfails.neg/eff_rtfails.