Skip to content

change confusing connection dialog names #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Grant Mulitz (gmulz) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

change confusing connection dialog names #752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions e2e/fixtures/with-robot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,12 @@ export const activateConnectionConfigByHost = async (page: Page, host: string) =

await expect(async () => {
const rows = page.locator('form').filter({
has: page.locator('input[placeholder="Host"]'),
has: page.locator('input[placeholder="Remote address"]'),
})
const count = await rows.count()
for (let index = 0; index < count; index += 1) {
const row = rows.nth(index)
if ((await row.locator('input[placeholder="Host"]').inputValue()) === host) {
if ((await row.locator('input[placeholder="Remote address"]').inputValue()) === host) {
const switchButton = row.getByRole('switch')
if ((await switchButton.getAttribute('aria-checked')) !== 'true') {
await switchButton.click()
Expand Down
6 changes: 3 additions & 3 deletions src/routes/lib/components/Machines.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@

<Input
class="input w-full grow text-xs"
placeholder="Host"
placeholder="Remote address"
value={config.host}
on:change={(event) => {
connectionConfigs.current[index].host = (event.target as HTMLInputElement).value
Expand Down Expand Up @@ -217,12 +217,12 @@

<label
for="{config.host}-address"
class="text-xs">Signaling address</label
class="text-xs">Address of signaling server</label
>
<div class="col-span-2">
<Input
id="{config.host}-address"
placeholder="Signaling address"
placeholder="Address of signaling server"
value={config.signalingAddress}
on:change={(event) => {
connectionConfigs.current[index].signalingAddress = (
Expand Down
Loading