Skip to content

app-16292: refactor Details panel into focused subcomponents #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Devin T. Currie (DTCurrie) merged 49 commits into from
Jun 3, 2026
Merged

app-16292: refactor Details panel into focused subcomponents #736

Show file tree
Hide file tree
Changes from 46 commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
faf59c0
Add shared ECS traits and helpers for entity pose plugins
DTCurrie Jun 1, 2026
9e637c6
Add changeset
DTCurrie Jun 1, 2026
02bc0d0
Refactor Details panel into focused subcomponents
DTCurrie Jun 1, 2026
bf49747
Add changeset
DTCurrie Jun 1, 2026
77eed59
Address review feedback on writeMatrix and useMouseRaycaster
github-actions[bot] Jun 1, 2026
c18c0e7
Merge branch 'main' into app-16292/1-ecs-utils
DTCurrie Jun 2, 2026
0d33dea
Address review feedback on Details refactor
github-actions[bot] Jun 2, 2026
dfef837
Address review feedback: writeMatrix early exit, undefined tests, fir…
github-actions[bot] Jun 2, 2026
4b68aae
Merge branch 'app-16292/1-ecs-utils' into app-16292/2-details-refactor
DTCurrie Jun 2, 2026
c00b48a
Update src/lib/ecs/traits.ts
DTCurrie Jun 2, 2026
2bcdba2
Merge branch 'app-16292/1-ecs-utils' into app-16292/2-details-refactor
DTCurrie Jun 2, 2026
b18c167
Add invalidate() to subcomponents and fix Details handleParentChange
github-actions[bot] Jun 2, 2026
fd1cd53
Apply suggestion from @claude[bot]
DTCurrie Jun 2, 2026
b890b95
fix claude's bad suggestion
DTCurrie Jun 2, 2026
82d5076
cleanup
DTCurrie Jun 2, 2026
1bc584f
Merge branch 'main' into app-16292/1-ecs-utils
DTCurrie Jun 2, 2026
8e8bc5e
Merge branch 'app-16292/1-ecs-utils' into app-16292/2-details-refactor
DTCurrie Jun 2, 2026
ddd050a
add handlers for changes
DTCurrie Jun 2, 2026
9ad63d7
use callbacks with no defaults
DTCurrie Jun 2, 2026
2450370
revert opacity behavior
DTCurrie Jun 2, 2026
081f852
split out opacity and axes helper details
DTCurrie Jun 2, 2026
f2b8a19
line color updates
DTCurrie Jun 2, 2026
4c7ab2f
default to first hit
DTCurrie Jun 2, 2026
d076b3f
Merge branch 'main' into app-16292/1-ecs-utils
DTCurrie Jun 2, 2026
b7b7d7c
Refactor Details panel into focused subcomponents
DTCurrie Jun 1, 2026
168cd3e
Add changeset
DTCurrie Jun 1, 2026
473af2e
Address review feedback on Details refactor
github-actions[bot] Jun 2, 2026
873a67b
Add invalidate() to subcomponents and fix Details handleParentChange
github-actions[bot] Jun 2, 2026
72a6fce
Apply suggestion from @claude[bot]
DTCurrie Jun 2, 2026
a92007c
fix claude's bad suggestion
DTCurrie Jun 2, 2026
2d7c9c1
cleanup
DTCurrie Jun 2, 2026
d5a080e
add handlers for changes
DTCurrie Jun 2, 2026
17e814f
use callbacks with no defaults
DTCurrie Jun 2, 2026
76b80ef
revert opacity behavior
DTCurrie Jun 2, 2026
053d6e1
split out opacity and axes helper details
DTCurrie Jun 2, 2026
51d9b2b
line color updates
DTCurrie Jun 2, 2026
d3f4b78
Merge branch 'app-16292/2-details-refactor' of github.com:viam-labs/m…
DTCurrie Jun 2, 2026
22b2dc9
Merge branch 'main' into app-16292/2-details-refactor
DTCurrie Jun 2, 2026
156feed
Apply suggestions from code review
DTCurrie Jun 3, 2026
299bed5
fix: correct useThrelte mock structure and remove duplicate guard
github-actions[bot] Jun 3, 2026
2cdca10
Apply suggestion from @claude[bot]
DTCurrie Jun 3, 2026
fb7f589
Apply suggestion from @claude[bot]
DTCurrie Jun 3, 2026
7d48588
claude is bad at suggesting code edits
DTCurrie Jun 3, 2026
5ccbd2b
remove outdated mock
DTCurrie Jun 3, 2026
84b0156
test: remove duplicate 'keeps original array intact' test case
github-actions[bot] Jun 3, 2026
8c7540a
remove old local matrix code
DTCurrie Jun 3, 2026
470ae90
cleanup
DTCurrie Jun 3, 2026
ac26da9
MatrixDetails -> PoseDetails
DTCurrie Jun 3, 2026
99d1188
Merge branch 'main' into app-16292/2-details-refactor
DTCurrie Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/details-panel-subcomponents.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@viamrobotics/motion-tools': patch
---

Split the Details overlay into focused subcomponents under `details/` and expose a `details-extensions` portal target for plugin-supplied editors
Loading
Loading