Skip to content

Document camera Stream and missing arm/gantry/gripper SDK methods#5186

Open
btshrewsbury-viam wants to merge 3 commits into
docs/api-getstatusfrom
docs/api-component-methods
Open

Document camera Stream and missing arm/gantry/gripper SDK methods#5186
btshrewsbury-viam wants to merge 3 commits into
docs/api-getstatusfrom
docs/api-component-methods

Conversation

@btshrewsbury-viam

Copy link
Copy Markdown
Collaborator

What this adds

Ten released component methods flagged by the weekly SDK method coverage job (#5142). Nine are documented protos whose newer SDK implementations were missing a column in sdk_protos_map.csv:

Resource Filled in
arm Flutter getKinematics, getGeometries
gantry Go Geometries, Flutter getGeometries/getKinematics, TypeScript getKinematics
gripper Flutter getCurrentInputs/goToInputs, TypeScript isHoldingSomething

The tenth is Go camera Stream (live video frames), added as a new manually-mapped row following the existing convention for non-proto SDK methods (like GetKinematics).

Base branch note

Stacked on #5184 (GetStatus) because both regenerate the same component markdown files — this PR's diff shows only its own changes. Merge #5184 first; GitHub will retarget this to main automatically.

Verification

Full local coverage run: all ten warnings cleared (49 → 39 relative to the #5184 baseline), no missing-override warnings. Flutter arm calculateMaxReach is deliberately not documented here — it is a client-side helper, tracked in the follow-up issue.

Refs #5142

…and gripper

The SDK method coverage job flagged ten released component methods
missing from the API reference. Nine are existing documented protos
that gained an SDK implementation without the CSV column being filled:

- arm: Flutter getKinematics, getGeometries
- gantry: Go Geometries, Flutter getGeometries/getKinematics,
  TypeScript getKinematics
- gripper: Flutter getCurrentInputs/goToInputs, TypeScript
  isHoldingSomething

The tenth is Go's camera Stream method (live video frames), added as a
new manually-mapped row following the existing convention for
non-proto SDK methods.

Regenerates the arm, gantry, gripper, and camera markdown.

Refs #5142.
The previous commit accidentally included regeneration drift for app,
robot, and base remote control files plus compiled Python bytecode,
none of which belong in this PR.
# Conflicts:
#	static/include/components/apis/generated/camera-table.md
@btshrewsbury-viam

Copy link
Copy Markdown
Collaborator Author

Merge order: merge #5184 first. This PR is stacked on the docs/api-getstatus branch because both regenerate the same component markdown files — the diff here shows only this PR's changes. Once #5184 merges, GitHub retargets this to main; merge it second (order relative to #5187 doesn't matter).

Issue linkage: refs #5142 but does not close it. The one arm method deliberately left undocumented here (Flutter calculateMaxReach, a client-side helper) is tracked in #5189.


Generated by Claude Code

@btshrewsbury-viam

Copy link
Copy Markdown
Collaborator Author

Hi Allison Chiang (@allisonschiang)! I think you might be the right person for the flutter arm & gantry changes, would you mind reviewing these changes?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only worked on getGeometries and getKinematics for arm and gantry but those seem right to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants