Skip to content

Update knative version to 1.9#662

Closed
anshalshukla wants to merge 5 commits into
vhive-serverless:mainfrom
anshalshukla:kn_1.9_upgrade
Closed

Update knative version to 1.9#662
anshalshukla wants to merge 5 commits into
vhive-serverless:mainfrom
anshalshukla:kn_1.9_upgrade

Conversation

@anshalshukla

Copy link
Copy Markdown
Contributor

Summary

Regular Update. Updated the knative version.

@anshalshukla anshalshukla requested a review from ustiugov January 28, 2023 07:01
@ustiugov ustiugov changed the title Update kn version Update knative version to 1.9 Jan 31, 2023
@ustiugov

Copy link
Copy Markdown
Member

@anshalshukla have you tested it with the workflow from the quickstart guide (with Firecracker and with containers)? Once you are done with testing, please ask @shyamjesal for a review.

@ustiugov

Copy link
Copy Markdown
Member

I noticed that the wiki page by Shyam doesn't really say about which repo and branch of serving one needs to take. @shyamjesal, could you please clarify this on the wiki page?

One needs to copy and rebase the following branch in our fork of Knative: ease-lab/serving#8

@shyamjesal

shyamjesal commented Jan 31, 2023

Copy link
Copy Markdown
Collaborator

Yes, that branch is correct, we need to update that branch and add the generated yamls. Wiki updated.

@ustiugov

ustiugov commented Feb 1, 2023

Copy link
Copy Markdown
Member

@anshalshukla please follow the updated wiki

@anshalshukla

Copy link
Copy Markdown
Contributor Author

Sure, I'll do it today

@anshalshukla

Copy link
Copy Markdown
Contributor Author

@shyamjesal I've updated the PR with the suggested branch and have also tested the workflows from quickstart guide.

@ustiugov

ustiugov commented Feb 3, 2023

Copy link
Copy Markdown
Member

@shyamjesal wait a bit. Anshal needs to rebase the copied branch first.

@ustiugov

ustiugov commented Feb 7, 2023

Copy link
Copy Markdown
Member

@anshalshukla any updates on this PR?

@anshalshukla

anshalshukla commented Feb 7, 2023

Copy link
Copy Markdown
Contributor Author

Updated knative using this branch. Tested the workflows and it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants