Skip to content

Magnus/lsp yql comments#33699

Open
Mangern wants to merge 8 commits into
masterfrom
magnus/lsp-yql-comments
Open

Magnus/lsp yql comments#33699
Mangern wants to merge 8 commits into
masterfrom
magnus/lsp-yql-comments

Conversation

@Mangern

@Mangern Mangern commented Mar 28, 2025

Copy link
Copy Markdown
Contributor

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

YQL comments supported in the parser and highlighted correctly in .yql files. They start with // as this was already defined in the parser.
Also added test for semantic token partitioning and refactored the testing boilerplate to make writing tests simpler.

@theodorklauritzen

Copy link
Copy Markdown
Contributor

This works almost great. However the comments inside the grouping language is not supported when querying. When trying to run queries from with the lsp with comments inside the grouping language, vespa responds with an error.

@Mangern

Mangern commented Apr 2, 2025

Copy link
Copy Markdown
Contributor Author

That makes sense, oops. It is of course not supported in the normal grouping parser. We could strip comments before sending the query. It would not conform with the normal parser, however I think being able to comment inside grouping language makes sense for an application like this.

@bratseth

bratseth commented Apr 2, 2025

Copy link
Copy Markdown
Member

Maybe we should just add it to the normal parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants