vstd/iter: Add spec for Iterator::find#2480
Open
ziqiaozhou wants to merge 3 commits into
Open
Conversation
Signed-off-by: Ziqiao Zhou <ziqiaozhou@microsoft.com>
parno
reviewed
May 29, 2026
Collaborator
parno
left a comment
parno
left a comment
There was a problem hiding this comment.
Thanks this will be quite helpful. Similar to my suggestion on #2479, could you please add a few examples of using this to the test suite? It would be great to have examples that show find returning Some and examples showing it returning None.
| final(self).obeys_prophetic_iter_laws() ==> (old(self).decrease() is Some <==> final(self).decrease() is Some), | ||
| // The final remaining elements are a subsequence of the old remaining. | ||
| final(self).obeys_prophetic_iter_laws() ==> { | ||
| &&& old(self).remaining().len() >= final(self).remaining().len() |
Collaborator
There was a problem hiding this comment.
I think we could omit the comment and simplify this to:
final(self).remaining().is_suffix_of(old(self).remaining())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.