Conversation
tjhance
reviewed
May 7, 2026
| /// Placeholder expression for the atomic update argument in the atomic function call | ||
| AtomicUpdateInitDummy, | ||
| /// Atomic function call | ||
| Atomically(AtomicCallInfo, VarIdent, Expr, bool), |
Collaborator
There was a problem hiding this comment.
What's the meaning of all these arguments?
Collaborator
Author
There was a problem hiding this comment.
I've replaced the bool with an AtomicallyKind enum, so it should be easier to read now
| pub fndef_axioms: Option<Exprs>, | ||
| /// MaskSpec that specifies what invariants the function is allowed to open | ||
| pub mask_spec: Option<MaskSpec>, | ||
| pub atomic_update: Option<Expr>, |
Collaborator
There was a problem hiding this comment.
I feel this should be a binder or a Param or something, rather than an arbitrary Expr.
Collaborator
Author
There was a problem hiding this comment.
We get this from the verus_builtin::atomic_spec<A>(_a: A) header function, so it is just an expression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends Verus with a built-in notion of logical atomicity, heavily inspired by its implementation in Iris.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.