Skip to content

rust_verify: improve error reporting on autoderive Clone #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bsdinis wants to merge 1 commit into from
+20 −9
Closed

rust_verify: improve error reporting on autoderive Clone #2263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions source/rust_verify/src/automatic_derive.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,6 @@ fn clone_add_post_condition<'tcx>(
.borrow_mut()
.push(VirErrAs::Warning(crate::util::err_span_bare(span, msg.to_string())));
};
let warn_unexpected = || {
warn(
"autoderive Clone impl does not take the form Verus expects; continuing, but without adding a specification for the derived Clone impl",
)
};
let warn_unsupported = || {
warn(
"Verus does not (yet) support autoderive Clone impl when the clone is not a copy; continuing, but without adding a specification for the derived Clone impl",
Expand All @@ -119,7 +114,11 @@ fn clone_add_post_condition<'tcx>(
self_var = Some(last_expr.clone());
}
_ => {
warn_unexpected();
warn(
"autoderive Clone impl does not take the form Verus expects:
A `clone` impl that ends by reading some variable should end with reading from `self`\n
continuing, but without adding a specification for the derived Clone impl",
);
return Ok(());
}
},
Expand All @@ -128,18 +127,30 @@ fn clone_add_post_condition<'tcx>(
self_var = None;
}
_ => {
warn_unexpected();
warn(
"autoderive Clone impl does not take the form Verus expects:
A `clone` impl should either read from self or call a constructor\n
continuing, but without adding a specification for the derived Clone impl",
);
return Ok(());
}
},
_ => {
warn_unexpected();
warn(
"autoderive Clone impl does not take the form Verus expects:
The `clone` function body should return a value\n
continuing, but without adding a specification for the derived Clone impl",
);
return Ok(());
}
}

if functionx.ensure.0.len() != 0 {
warn_unexpected();
warn(
"autoderive Clone impl does not take the form Verus expects:
The `clone` function should only have default trait ensure clauses\n
continuing, but without adding a specification for the derived Clone impl",
);
return Ok(());
}

Expand Down
Loading