New built-in SCTP stack#1806
Conversation
# Details - Add `SctpOptions::Dump()`. - Increase channel max message/payload length (just because it's free). - Cosmetic and more SCPT TODO items.
|
@jmillan I've pushed those typo fixes mentioned above in my last commit plus Rust part 1. |
|
Apologies for hijacking this thread to ask a question related to the SCTP rework: We (Threema) use the data channels fairly extensively via mediasoup. Would you be interested in getting feedback, and if so, when would be a good place to start testing? |
There will be another PR after this to complete pending TODO items. See TODO_SCTP.md file in this branch. I will announce it in Announcements category in the mediasoup forum. The |
TODO 1UPDATE: Fixed.
cargo test --test integration smoke::
Finished `test` profile [unoptimized + debuginfo] target(s) in 0.19s
Running tests/integration/main.rs (/Volumes/src-cs/mediasoup/target/debug/deps/integration-e713b03692d22943)
running 1 test (forever) |
Note: Radical change here. This PR will NOT keep |
|
@threema-lenny this branch is ready to test. Please read the PR description and take into account that, even if I didn't say it in there, the SCTP parameters generated by this mediasoup branch are still compatible with those that mediasoup-client requires. |
Details
usrsctp.useBuiltInSctpStackoption inWorkerSettngs.SctpCapabilitiestype. No longer needed.WebRtcTransport,PlainTransport,PipeTransport: AddsctpNegotiatedCapabilities()getter.WebRtcTransport,PlainTransport,PipeTransportoptions: RemovenumSctpStreamsandmaxSctpMessageSize, and addmaxSendMessageSize,maxReceiveMessageSize,sctpPerStreamSendQueueLimitandsctpMaxReceiverWindowBufferSize.DirectTransportoptions: RemovemaxMessageSize, and addmaxSendMessageSizeandmaxReceiveMessageSize.SctpParameterstype from{ port, OS, MIS, maxMessageSize }to{ port, maxSendMessageSize, maxReceiveMessageSize, sendBufferSize, perStreamSendQueueLimit, maxReceiverWindowBufferSize, isDataChannel}.Notes