[cli] [core] Probe deployment specVersion before CLI start#1629
Open
VaguelySerious wants to merge 2 commits intopeter/cbor-transport-compatfrom
Open
[cli] [core] Probe deployment specVersion before CLI start#1629VaguelySerious wants to merge 2 commits intopeter/cbor-transport-compatfrom
VaguelySerious wants to merge 2 commits intopeter/cbor-transport-compatfrom
Conversation
CLI start command now queries the deployment's health check endpoint to determine its specVersion before calling start(). This ensures the correct queue transport is used (JSON for old deployments, CBOR for new). Falls back to the run's specVersion if health check fails. Health check always uses JSON transport (specVersion: SPEC_VERSION_LEGACY) so the probe works against both old and new deployments. Also adds deploymentId option to HealthCheckOptions for targeted health checks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: e2d9425 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (61 failed)mongodb-dev (1 failed):
redis-dev (1 failed):
turso-dev (1 failed):
turso (58 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Based on #1627. CLI
startcommand now probes the target deployment's specVersion via health check before callingstart(), ensuring the correct queue transport is used.specVersion: SPEC_VERSION_LEGACY) so the probe works against both old and new deploymentsdeploymentIdoption toHealthCheckOptionsfor targeted health checksspecVersionif health check fails (e.g. old deployment without health check support)Other paths that call
start()without knowing specVersionstartrecreateRunFromExisting(web dashboard replay)run.specVersionfrom original runimport { start } from 'workflow')SPEC_VERSION_CURRENTis correctworld-testing)Test plan
packages/coreunit tests pass (580/580)startagainst old deployment uses JSON transportstartagainst new deployment uses CBOR transportstartwith health check timeout falls back to run specVersion🤖 Generated with Claude Code