fix(next): remove unused dataDir option from withWorkflow()#1619
Open
johnlindquist wants to merge 1 commit intomainfrom
Open
fix(next): remove unused dataDir option from withWorkflow()#1619johnlindquist wants to merge 1 commit intomainfrom
johnlindquist wants to merge 1 commit intomainfrom
Conversation
The `dataDir` option was accepted in the type definition but never read — `WORKFLOW_LOCAL_DATA_DIR` was unconditionally set to `.next/workflow-data`. Remove the dead option to avoid confusion.
Contributor
🦋 Changeset detectedLatest commit: 0a02e41 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
workflow with 1 step💻 Local Development
workflow with 10 sequential steps💻 Local Development
workflow with 25 sequential steps💻 Local Development
workflow with 50 sequential steps💻 Local Development
Promise.all with 10 concurrent steps💻 Local Development
Promise.all with 25 concurrent steps💻 Local Development
Promise.all with 50 concurrent steps💻 Local Development
Promise.race with 10 concurrent steps💻 Local Development
Promise.race with 25 concurrent steps💻 Local Development
Promise.race with 50 concurrent steps💻 Local Development
workflow with 10 sequential data payload steps (10KB)💻 Local Development
workflow with 25 sequential data payload steps (10KB)💻 Local Development
workflow with 50 sequential data payload steps (10KB)💻 Local Development
workflow with 10 concurrent data payload steps (10KB)💻 Local Development
workflow with 25 concurrent data payload steps (10KB)💻 Local Development
workflow with 50 concurrent data payload steps (10KB)💻 Local Development
Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
stream pipeline with 5 transform steps (1MB)💻 Local Development
10 parallel streams (1MB each)💻 Local Development
fan-out fan-in 10 streams (1MB each)💻 Local Development
SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (64 failed)mongodb (4 failed):
redis (3 failed):
turso (57 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
|
johnlindquist
added a commit
that referenced
this pull request
Apr 6, 2026
- Remove type signature code blocks from fatal-error.mdx and retryable-error.mdx (match pattern used by other API ref pages) - Use HookNotFoundError.is() static method instead of fragile string-based error.name checks in resume-hook.mdx examples - Distinguish 404 (hook not found) from 500 (other errors) in define-hook.mdx resume example - Remove dataDir from with-workflow.mdx options table (unused option, removal PR: #1619)
karthikscale3
approved these changes
Apr 6, 2026
johnlindquist
added a commit
that referenced
this pull request
Apr 6, 2026
- Remove type signature code blocks from fatal-error.mdx and retryable-error.mdx (match pattern used by other API ref pages) - Use HookNotFoundError.is() static method instead of fragile string-based error.name checks in resume-hook.mdx examples - Distinguish 404 (hook not found) from 500 (other errors) in define-hook.mdx resume example - Remove dataDir from with-workflow.mdx options table (unused option, removal PR: #1619)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dataDiroption fromwithWorkflow()'s type definition — it was accepted but never readWORKFLOW_LOCAL_DATA_DIRis unconditionally set to.next/workflow-dataon line 53, ignoring any user-provided valueTest plan
pnpm typecheckpasses