fix: prioritize shikiTheme prop over code plugin default theme#497
Open
sleitor wants to merge 2 commits intovercel:mainfrom
Open
fix: prioritize shikiTheme prop over code plugin default theme#497sleitor wants to merge 2 commits intovercel:mainfrom
sleitor wants to merge 2 commits intovercel:mainfrom
Conversation
Contributor
|
@sleitor is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Remove the destructuring default so shikiTheme can be undefined, making plugins?.code?.getThemes() actually reachable as a fallback. Priority chain: explicit prop > code plugin > defaultShikiTheme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #496
The
shikiThemeprop was being overridden by the code plugin's default theme due to incorrect nullish coalescing order. The prop should take priority over the plugin default, matching the documented behavior.\n\n### Changes\n- Swapped the nullish coalescing order soshikiThemeprop takes precedence overplugins?.code?.getThemes()