Skip to content

fix(mermaid): add aria-hidden to decorative SVG icons in toolbar buttons #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sleitor wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −6
Open

fix(mermaid): add aria-hidden to decorative SVG icons in toolbar buttons #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .changeset/fix-mermaid-aria-hidden.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
'streamdown': patch
---

fix(mermaid): add aria-hidden to decorative SVG icons in mermaid toolbar buttons

Mermaid toolbar buttons (download, fullscreen, pan/zoom controls) already have
accessible titles/labels, but the inline SVG icons were exposed to the accessibility
tree causing "Content with images must be labeled" warnings. Added aria-hidden={true}
to all decorative icon elements in download-button, fullscreen-button, and pan-zoom
components.

Fixes #485
2 changes: 1 addition & 1 deletion packages/streamdown/lib/mermaid/download-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export const MermaidDownloadDropdown = ({
title={t.downloadDiagram}
type="button"
>
{children ?? <icons.DownloadIcon size={14} />}
{children ?? <icons.DownloadIcon aria-hidden={true} size={14} />}
</button>
{isOpen ? (
<div
Expand Down
4 changes: 2 additions & 2 deletions packages/streamdown/lib/mermaid/fullscreen-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export const MermaidFullscreenButton = ({
type="button"
{...props}
>
<Maximize2Icon size={14} />
<Maximize2Icon aria-hidden={true} size={14} />
</button>

{isFullscreen
Expand All @@ -115,7 +115,7 @@ export const MermaidFullscreenButton = ({
title={t.exitFullscreen}
type="button"
>
<XIcon size={20} />
<XIcon aria-hidden={true} size={20} />
</button>
{/* biome-ignore lint/a11y/noStaticElementInteractions: "div with role=presentation is used for event propagation control" */}
<div
Expand Down
6 changes: 3 additions & 3 deletions packages/streamdown/lib/mermaid/pan-zoom.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ export const PanZoom = ({
title="Zoom in"
type="button"
>
<ZoomInIcon size={16} />
<ZoomInIcon aria-hidden={true} size={16} />
</button>
<button
className={cn(
Expand All @@ -186,7 +186,7 @@ export const PanZoom = ({
title="Zoom out"
type="button"
>
<ZoomOutIcon size={16} />
<ZoomOutIcon aria-hidden={true} size={16} />
</button>
<button
className={cn(
Expand All @@ -196,7 +196,7 @@ export const PanZoom = ({
title="Reset zoom and pan"
type="button"
>
<RotateCcwIcon size={16} />
<RotateCcwIcon aria-hidden={true} size={16} />
</button>
</div>
) : null}
Expand Down
Loading