fix: mention params and searchParams in blocking-route error messages#92360
Merged
aurorascharff merged 8 commits intocanaryfrom Apr 8, 2026
Merged
fix: mention params and searchParams in blocking-route error messages#92360aurorascharff merged 8 commits intocanaryfrom
aurorascharff merged 8 commits intocanaryfrom
Conversation
The Dynamic variant of the blocking-route error said "Uncached data" without mentioning params or searchParams, making it hard to connect the error to await params in a Page component. Made-with: Cursor
Collaborator
Tests Passed |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the “blocking-route” Dynamic-variant error messaging to explicitly mention params and searchParams, making it easier to connect common causes like await params with the linked remediation guidance.
Changes:
- Expanded the Dynamic variant of the blocking-route error description to include
paramsandsearchParams. - Updated both dynamic-rendering runtime message sites to keep wording consistent.
- Updated
errors.jsonentry1084to match the new message text.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/next/src/server/app-render/dynamic-rendering.ts | Updates Dynamic blocking-route error strings to mention params/searchParams. |
| packages/next/errors.json | Updates error message 1084 to match the new Dynamic blocking-route wording. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📝 Changed Files (8 files)Files with changes:
View diffsapp-page-exp..ntime.dev.jsfailed to diffapp-page-exp..time.prod.jsDiff too large to display app-page-tur..ntime.dev.jsfailed to diffapp-page-tur..time.prod.jsDiff too large to display app-page-tur..ntime.dev.jsfailed to diffapp-page-tur..time.prod.jsDiff too large to display app-page.runtime.dev.jsfailed to diffapp-page.runtime.prod.jsDiff too large to display 📎 Tarball URL |
Made-with: Cursor
Contributor
There was a problem hiding this comment.
Additional Suggestions:
- Inline snapshot in instant-validation-build test contains stale error message "Uncached data or
connection()" that no longer matches the updated source code.
- Test inline snapshots contain the old error message "Uncached data or
connection()" but the source code was updated to "Uncached data,params,searchParams, orconnection()", causing 8 test failures.
gnoff
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds
paramsandsearchParamsto the Dynamic variant of the blocking-route error message.Why?
When
const { id } = await paramsin a Page component triggers the blocking-route error, the message says "Uncached data orconnection()was accessed outside of<Suspense>" — which doesn't mentionparamsat all. This makes it hard for developers and AI agents to connect the error toawait paramsbeing the cause, or to find the "Params and SearchParams" fix section in the linked error doc.How?
Updated two error message strings in
dynamic-rendering.ts(and the correspondingerrors.jsonentry) to includeparamsandsearchParamsalongside "Uncached data" andconnection().PR checklist (Fixing a bug)
Made with Cursor