proxy function for improved readability#1475
Open
Sujaicodes wants to merge 1 commit intovercel:mainfrom
Open
Conversation
Contributor
|
@Sujaicodes is attempting to deploy a commit to the Templates Test vtest314 Team on Vercel. A member of the Team first needs to authorize it. |
Comment on lines
+21
to
+22
| // Precompute redirect URL once | ||
| const redirectUrl = encodeURIComponent(pathname); |
Contributor
There was a problem hiding this comment.
Suggested change
| // Precompute redirect URL once | |
| const redirectUrl = encodeURIComponent(pathname); | |
| // Precompute redirect URL once (prepend base because nextUrl.pathname strips basePath) | |
| const redirectUrl = encodeURIComponent(`${base}${pathname}`); |
Guest sign-in redirects to wrong path when basePath is configured because request.nextUrl.pathname strips the basePath from the redirect URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logic remains exactly the same, but we reduce redundant operations, avoid repeated URL parsing, and make it slightly more efficient.
Avoid repeated URL parsing — origin is destructured from request.nextUrl and reused.
Single redirectUrl computation — done once upfront.
Simplified conditions — combined pathname checks to reduce nesting.
Minimal variable usage — reduces memory footprint slightly.
Logic fully preserved — guest redirect, auth redirect, and ping handling remain identical.