feat(openai-compatible): emit warning when using kebab-case instead of camelCase#14177
Open
aayush-kapoor wants to merge 2 commits intomainfrom
Open
feat(openai-compatible): emit warning when using kebab-case instead of camelCase#14177aayush-kapoor wants to merge 2 commits intomainfrom
aayush-kapoor wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
there was a TODO introduced in #11838 that talked about deprecating any providerOptions use that are defined with a
kebab-casekey.for user facing APIs we should use camelCase. we should deprecate and eventually remove all other provider options
Summary
type: deprecatedadded that will allow us to use/emit a similar warning for other providerswarnIfDeprecatedProviderOptionsKeythat will emit the warningskebab-caseproviderOptions will still workManual Verification
verified by running the example
examples/ai-functions/src/generate-text/openai/compatible-chat-provider-options.tsbefore and after to see if the warning was emittedChecklist
pnpm changesetin the project root)