fix(prompt): skip generating download requests for data URLs#14131
Open
Diode11-Alt wants to merge 1 commit intovercel:mainfrom
Open
fix(prompt): skip generating download requests for data URLs#14131Diode11-Alt wants to merge 1 commit intovercel:mainfrom
Diode11-Alt wants to merge 1 commit intovercel:mainfrom
Conversation
This fixes an issue introduced in \`@ai-sdk/provider-utils@4.0.19\` where stricter SSRF URL validation caused \`data:\` URLs to be rejected during the \`downloadAssets\` phase, since \`validateDownloadUrl\` only allows \`http:\` and \`https:\`. Since \`data:\` URLs are inline payloads and don't need actually downloading, they should be filtered out from the \`plannedDownloads\` array altogether. Fixes vercel#13103
tigent
bot
added
ai/core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13103
Description
This fixes a critical regression where valid `data:` URLs (e.g. inline images, pdfs) are rejected due to stricter SSRF URL validation in `downloadAssets`.
Since `data:` URLs represent inline data and are not remote resources that need downloading, they should be filtered out from the `plannedDownloads` array altogether rather than being passed into the `download` map.
Changes