Fix: CheckerFramework version bump#393
Open
byd110 wants to merge 2 commits into
Open
Conversation
Author
|
add new test cases to test that extends "c" is rejected. |
wmdietl
requested changes
Feb 1, 2026
wmdietl
left a comment
Contributor
There was a problem hiding this comment.
Thanks for tracking down the version update problems!
| } | ||
|
|
||
| void testGlb1() { | ||
| // ::error: (assignment.type.incompatible) |
Contributor
There was a problem hiding this comment.
For the removed errors, can you instead say what the effective bound is?
I think it's fine that we no longer get the assignment errors, but the effective bounds should still give us the desired behavior. Is that the case?
| checkerFramework: "3.42.0-eisop5", | ||
| ] | ||
|
|
||
| //def checkerframework_local = true // Set this variable to [true] while using local version of checker framework. |
Contributor
There was a problem hiding this comment.
I think these can be removed, as nobody uses the variables.
| @@ -10,6 +10,9 @@ ext.versions = [ | |||
| checkerFramework: "3.42.0-eisop5", | |||
Contributor
There was a problem hiding this comment.
Can you look for all uses of the version string and update them together?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CF version bump #349 fails at the test to compute the greatest lower bound and lowest upper bound. Consider the code snippet:
Problem Description
Here the object creation should be valid if we compute the lub as
@AllowedAlgorithms({"a"}) String. However, in the handling before 3.43.0 release is that it takes the upper bound at class decl directly, which is@AllowedAlgorithms({"a", "b"}. Hence, here was expected anassignment.type.incompatibleerror before.Solution
By removing this type of error specifications, and adapt the change of CF APIs (some signatures changed from
BaseTypeCheckertoSourceChecker), the build succeed.