fix(claude-code): resolve directoryBankMap by nearest ancestor - #2812
Open
r266-tech wants to merge 1 commit into
Open
fix(claude-code): resolve directoryBankMap by nearest ancestor#2812r266-tech wants to merge 1 commit into
r266-tech wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
directoryBankMapentries apply to descendant working directoriesThis addresses the Claude Code routing failure reported in #2519: after the agent changes into a project subdirectory, retain/recall operations continue using the configured project bank instead of silently falling back.
The issue also notes Codex dynamic project IDs. I intentionally left that separate: changing Codex's existing directory-derived IDs requires an explicit migration/compatibility design for memories already stored under legacy subdirectory banks.
Verification
PYTHONPATH=scripts .venv/bin/python -m pytest tests/test_bank.py -q— 58 passedgit diff --checkReview notes
Adversarial review drove explicit coverage for nested roots, sibling-prefix boundaries, Windows drive/UNC behavior, symlink containment, canonical alias conflicts, order independence, and mutable-realpath snapshot consistency. Exact symlink equality and POSIX case semantics remain compatible with current behavior; the new lexical guard applies to descendant expansion.