Skip to content

fix: v2 apis#627

Draft
davidecarpini wants to merge 4 commits into
mainfrom
multisig-veworld-v2-apis
Draft

fix: v2 apis#627
davidecarpini wants to merge 4 commits into
mainfrom
multisig-veworld-v2-apis

Conversation

@davidecarpini
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a0bdcb2f-f682-4317-a897-4c4ce7b13b56

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch multisig-veworld-v2-apis

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Agilulfo1820
Copy link
Copy Markdown
Member

Agilulfo1820 commented May 20, 2026

Ad back logout btn in the address field (near the copy btn) as it was before, since the new pattern is a bit weird (with 2 full btns and an icon btn).
Or let's find an alternative ui

@davidecarpini
Copy link
Copy Markdown
Member Author

removed the button on veworld as discussed and tested on wallet-connect and social-login and looks good @Agilulfo1820
Screenshot 2026-05-21 at 11 56 28
Screenshot 2026-05-21 at 11 56 10
Screenshot 2026-05-21 at 11 55 31

@Agilulfo1820
Copy link
Copy Markdown
Member

@davidecarpini some issue with the build to fix:

Error: @vechain/vechain-kit#build: command (/home/runner/work/vechain-kit/vechain-kit/packages/vechain-kit) /tmp/xfs-7cbb0a65/yarn run build exited (2) cache miss, executing a3546dc0e32739f7 src/components/AccountModal/Contents/SelectWallet/SelectWalletContent.tsx(63,9): error TS2339: Property 'requestPermissions' does not exist on type '{ setSource: (source: WalletSource) => void; availableWallets: WalletSource[]; disconnect: () => void; connect: ConnectCallback; account: string | null; ... 12 more ...; isSwitchWalletEnabled: boolean; }'. src/components/AccountModal/Contents/SelectWallet/SelectWalletContent.tsx(64,9): error TS2339: Property 'revokeAccount' does not exist on type '{ setSource: (source: WalletSource) => void; availableWallets: WalletSource[]; disconnect: () => void; connect: ConnectCallback; account: string | null; ... 12 more ...; isSwitchWalletEnabled: boolean; }'. src/components/AccountModal/Contents/SelectWallet/SelectWalletContent.tsx(384,29): error TS7006: Parameter 'e' implicitly has an 'any' type. src/hooks/api/wallet/useWallet.ts(98,9): error TS2339: Property 'accounts' does not exist on type '{ setSource: (source: WalletSource) => void; availableWallets: WalletSource[]; disconnect: () => void; connect: ConnectCallback; account: string | null; ... 12 more ...; isSwitchWalletEnabled: boolean; }'. src/hooks/api/wallet/useWallet.ts(99,9): error TS2339: Property 'setActiveAccount' does not exist on type '{ setSource: (source: WalletSource) => void; availableWallets: WalletSource[]; disconnect: () => void; connect: ConnectCallback; account: string | null; ... 12 more ...; isSwitchWalletEnabled: boolean; }'.

@Agilulfo1820
Copy link
Copy Markdown
Member

@davidecarpini solved a conflict, kept both my and your changes.
My changes were to fix a bug with wallet connect modal not closing

@Agilulfo1820 Agilulfo1820 added safe-to-deploy Label to approve external PRs to preview environment safe-to-build labels May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe-to-build safe-to-deploy Label to approve external PRs to preview environment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants