Skip to content

Separated statistics-only from main backend admin permission; #100 #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Eoler wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Separated statistics-only from main backend admin permission; #100 #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions Plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ public function registerPermissions(): array
'label' => 'vdlp.redirect::lang.permission.access_redirects.label',
'tab' => 'vdlp.redirect::lang.permission.access_redirects.tab',
],
'vdlp.redirect.access_redirect_statistics' => [
'label' => 'vdlp.redirect::lang.permission.access_redirect_statistics.label',
'tab' => 'vdlp.redirect::lang.permission.access_redirects.tab',
],
];
}

Expand Down Expand Up @@ -150,7 +154,7 @@ public function registerNavigation(): array
'url' => $defaultBackendUrl,
'order' => 201,
'permissions' => [
'vdlp.redirect.access_redirects',
'vdlp.redirect.*',
],
'sideMenu' => $sideMenu,
],
Expand All @@ -163,7 +167,7 @@ public function registerNavigation(): array
'url' => Backend::url('vdlp/redirect/statistics'),
'order' => 10,
'permissions' => [
'vdlp.redirect.access_redirects',
'vdlp.redirect.access_redirect_statistics',
],
];
}
Expand Down Expand Up @@ -225,6 +229,9 @@ public function registerReportWidgets(): array
'vdlp.redirect::lang.buttons.create_redirect'
)),
'context' => 'dashboard',
'permissions' => [
'vdlp.redirect.access_redirects',
],
];
}

Expand All @@ -237,6 +244,9 @@ public function registerReportWidgets(): array
]
)),
'context' => 'dashboard',
'permissions' => [
'vdlp.redirect.access_redirect_statistics',
],
];
}

Expand Down
2 changes: 1 addition & 1 deletion controllers/Statistics.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
*/
final class Statistics extends Controller
{
public $requiredPermissions = ['vdlp.redirect.access_redirects'];
public $requiredPermissions = ['vdlp.redirect.access_redirect_statistics'];
private StatisticsHelper $helper;

public function __construct()
Expand Down
3 changes: 3 additions & 0 deletions lang/en/lang.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
'label' => 'Redirects',
'tab' => 'Redirects',
],
'access_redirect_statistics' => [
'label' => 'Redirect Statistics',
],
],
'navigation' => [
'menu_label' => 'Redirects',
Expand Down
3 changes: 3 additions & 0 deletions lang/nl/lang.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
'label' => 'Redirects',
'tab' => 'Redirects',
],
'access_redirect_statistics' => [
'label' => 'Redirect statistieken',
],
],
'navigation' => [
'menu_label' => 'Redirects',
Expand Down