Document safe dynamic reflection updates - #50
Draft
vanderlee wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
innerHTMLWhy
The pattern in issue #14 reads and rewrites the container's entire
innerHTML. That recreates every cover and reflection node. Canvas pixel content is not represented in serialized HTML, and the reflection plugin's jQuery state is attached to the original DOM nodes, so neither can survive that replacement.Appending the new image in place preserves all existing nodes. Applying the reflection plugin to only the new image before calling
coverflow('refresh')integrates it with the existing reflected covers.Closes #14.
Validation
node --check jquery.coverflow.jsgit diff --check