feat(sca): Add bottom sheet for prompting smart account upgrades when available#285
Open
jophish wants to merge 22 commits into
Open
feat(sca): Add bottom sheet for prompting smart account upgrades when available#285jophish wants to merge 22 commits into
jophish wants to merge 22 commits into
Conversation
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If an account is able to be upgraded to a smart account, a bottom sheet is shown prompting the user to upgrade before sending the transaction. If the request did not mark atomicity as required, the user can continue with the transaction without upgrading (potentially executing send calls individually/sequentially). If
atomicRequiredis true on the TX, the user must upgrade their account in order to continue with the transaction.Test plan
See video. First example is when upgrading is optional, second is required.
smart-account-upgrade-2025-10-16_16.23.50.mp4
Related issues
Backwards compatibility
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: