feat(Angular): update to v21 - #1298
Conversation
Ran `npx nx migrate latest`. Had to manually add `standalone: false` to components created in test files, otherwise was all automatic.
|
Hi @AlDrag thnks for your contriubution, but this won't make lib to support angular 21, we got to update peerDependencies in the lib itself. |
|
@lexasq I've updated the peer dependencies to Angular v21. Sorry about that. Thanks. |
|
Thanks again, probably one last thing left is to update test run, as we update Jest version here.
NX Running target test for project ng2-file-upload × nx run ng2-file-upload:test ` |
|
I just realised I never actually ran I think we are blocked on this PR being merged for ngx-bootstrap valor-software/ngx-bootstrap#6788 |
|
Yeah, that would be my chore. I'll work it out |
|
Sweet, thank you. The tests all pass on my end otherwise, so not sure why you're getting that jest error. But I'll reconfirm when |
|
any update here? ngx-bootstrap was updated. |
|
@lexasq I've updated ngx-bootstrap. |
Ran
npx nx migrate latest. Had to manually addstandalone: falsetocomponents created in test files, otherwise was all automatic.
Ran manual steps from Github
on-push-or-pullActions and is all passing.