Skip to content

feat(Angular): update to v21 - #1298

Merged
lexasq merged 4 commits into
valor-software:developmentfrom
AlDrag:development
Mar 5, 2026
Merged

lexasq merged 4 commits into
valor-software:developmentfrom
AlDrag:development

Conversation

@AlDrag

@AlDrag AlDrag commented Jan 20, 2026 •

Copy link
Copy Markdown
Contributor

Ran npx nx migrate latest. Had to manually add standalone: false to
components created in test files, otherwise was all automatic.

Ran manual steps from Github on-push-or-pull Actions and is all passing.

Ran `npx nx migrate latest`.
Had to manually add `standalone: false` to
components created in test files, otherwise
was all automatic.
@AlDrag AlDrag mentioned this pull request Jan 20, 2026
@lexasq

lexasq commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

Hi @AlDrag thnks for your contriubution, but this won't make lib to support angular 21, we got to update peerDependencies in the lib itself.
provideZoneChangeDetection() is not required since AppComponent is standalone: false.
Please update lib peerDependencies, and for possible

@AlDrag

AlDrag commented Jan 28, 2026

Copy link
Copy Markdown
Contributor Author

@lexasq I've updated the peer dependencies to Angular v21. Sorry about that.
I've also removed provideZoneChangeDetection(). I didn't read the docs properly.

Thanks.

@lexasq

lexasq commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

Thanks again, probably one last thing left is to update test run, as we update Jest version here.
`> ng2-file-upload-demo@9.0.0 test

nx run-many --target=test --all

NX Running target test for project ng2-file-upload

× nx run ng2-file-upload:test
NX ● Validation Error:

    Test environment jest-environment-jsdom cannot be found. Make sure the testEnvironment configuration option points to an existing node module.

    Configuration Documentation:
    https://jestjs.io/docs/configuration


  As of Jest 28 "jest-environment-jsdom" is no longer shipped by default, make sure to install it separately.
  Pass --verbose to see the stacktrace.

`

@AlDrag

AlDrag commented Jan 28, 2026

Copy link
Copy Markdown
Contributor Author

I just realised I never actually ran npm install at the root. Getting conflicts.

I think we are blocked on this PR being merged for ngx-bootstrap valor-software/ngx-bootstrap#6788

@lexasq

lexasq commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

Yeah, that would be my chore. I'll work it out

@AlDrag

AlDrag commented Jan 29, 2026

Copy link
Copy Markdown
Contributor Author

Sweet, thank you.

The tests all pass on my end otherwise, so not sure why you're getting that jest error. But I'll reconfirm when ngx-bootstrap is updated.

@atpanos

atpanos commented Feb 13, 2026

Copy link
Copy Markdown

any update here? ngx-bootstrap was updated.

@AlDrag

AlDrag commented Feb 24, 2026

Copy link
Copy Markdown
Contributor Author

@lexasq I've updated ngx-bootstrap.

@lexasq
lexasq merged commit dd04197 into valor-software:development Mar 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants