refactor: do not focus overlay item after opening breadcrumbs overlay#11885
Merged
Conversation
web-padawan
changed the title
web-padawan
force-pushed
the
fix/breadcrumbs-overlay-focus
branch
from
61f4e08 to
96d5e98
Compare
jouni
approved these changes
Jun 8, 2026
Update the overflow overlay spec so focus stays on the overflow button when the overlay opens; the first ArrowDown / ArrowUp keypress is what moves focus into the overlay (ArrowDown to the first item, ArrowUp to the last). Matches the <vaadin-menu-bar> precedent and avoids a focus ring on pointer opens. The "skip disabled overlay items" Discussion entry drops the now-stale reference to an open-time first-focus path, and a new Discussion entry records the rationale for the change.
web-padawan
force-pushed
the
fix/breadcrumbs-overlay-focus
branch
from
96d5e98 to
9834688
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #11876, addressing the approach suggested by Jouni in #11876 (comment): rather than masking the focus ring on the auto-focused first item, do not move focus at all when the overlay opens.
KeyboardDirectionMixin._getAvailableIndexso the open-time handoff matches the per-keystroke contract.<vaadin-menu-bar>precedent.Related to #11876
🤖 Generated with Claude Code