Created a yaml file for HPA

[Rajdeep1311]

What do these changes do?

Created a yaml file for Horizontal Pod Autoscaler (HPA) that scales up and down the vineyard cluster according to the memory usage by the cluster

Related issue number

Fixes #1302

[dashanji]

@Rajdeep1311 The target should not be the vineyard-controller-manager, and it should be the vineyard cluster. Please refer the doc https://v6d.io/notes/cloud-native/deploy-kubernetes.html#option-1-install-from-helm-chart-recommended

[Rajdeep1311]

@dashanji Sir am I supposed to include the HPA in such a way that when the vineyard cluster is deployed, the hpa also runs. And include the values of hpa in values.yaml?

[dashanji]

okay， after that you would better to add a doc to show a complete example.

[Rajdeep1311]

okay， after that you would better to add a doc to show a complete example.

@dashanji Sure sir

[Rajdeep1311]

@dashanji Sir, could you please review the PR?

[dashanji]

Hi @Rajdeep1311, I think you may misunderstand the target resource defined in the scaleTargetRef. It should be the vineyard cluster rather than the vineyard operator.
You can refer to the doc (https://v6d.io/tutorials/kubernetes/using-vineyard-operator.html) to create a vineyard cluster and get some insights from it.

[Rajdeep1311]

@dashanji okay sir, I will see to it

[Rajdeep1311]

Hi @Rajdeep1311, I think you may misunderstand the target resource defined in the scaleTargetRef. It should be the vineyard cluster rather than the vineyard operator. You can refer to the doc (https://v6d.io/tutorials/kubernetes/using-vineyard-operator.html) to create a vineyard cluster and get some insights from it.

Sir @dashanji , will the scaleTargetRef be the vineyard cluster created as a custom resource?

[dashanji]

Sir @dashanji , will the scaleTargetRef be the vineyard cluster created as a custom resource?

Yes.

[Rajdeep1311]

Sir @dashanji , will the scaleTargetRef be the vineyard cluster created as a custom resource?

Yes.

Sir, I am facing a problem, the vineyardd custom resource (CR) isn't populating the .status.selector, I need that field so that the HPA can patch up with the cluster. As of now, I'm getting a selector is required error from the HPA that I am creating. I need the selectors so that HPA can identify the vineyard cluster.

Also, can we connect somewhere so that it will be easier for us to communicate?

[dashanji]

Sir, I am facing a problem, the vineyardd custom resource (CR) isn't populating the .status.selector, I need that field so that the HPA can patch up with the cluster. As of now, I'm getting a selector is required error from the HPA that I am creating. I need the selectors so that HPA can identify the vineyard cluster.

You can use the vineyard deployments' selector rather than the vineyardd CR.

[Rajdeep1311]

Sir, I am facing a problem, the vineyardd custom resource (CR) isn't populating the .status.selector, I need that field so that the HPA can patch up with the cluster. As of now, I'm getting a selector is required error from the HPA that I am creating. I need the selectors so that HPA can identify the vineyard cluster.

You can use the vineyard deployments' selector rather than the vineyardd CR.

Yeah, sir, I will get it from the deployment, but I think I was not able to communicate my question properly.
So, will I point the scaleTargetRef to the deployment created by the vineyard custom resource? But we need to scale the vineyard custom resource, right, Sir, not the deployment created by the custom resource? @dashanji

If we need to scale the custom resource itself, then the HPA needs the status.selector field to be populated on creation of the CR, we cannot provide that manually, sir, but it is not happening. The HPA needs status.selector to identify the CR.

@dashanji

[github-actions]

/cc @sighingnow, this issus/pr has had no activity for a long time, please help to review the status and assign people to work on it.