You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/cut/cut-huge-range is now being skipped but was previously passing.
Thanks for digging into this and opening a fix! While looking at this issue more closely, it turns out there's also an underlying implementation bug: GNU install calls umask(0) at startup so ancestor directories always land at exactly 0755, but uutils doesn't, meaning restrictive umasks like 0027 or 0111 produce wrong ancestor modes beyond just the test failure you caught. Filed that as #12714 and opened #12715 to fix both the implementation and replace the probe-based assertions with the correct assert_eq!(0o40_755) checks. Hopefully useful context!
Thanks for digging into this and opening a fix! While looking at this issue more closely, it turns out there's also an underlying implementation bug: GNU install calls umask(0) at startup so ancestor directories always land at exactly 0755, but uutils doesn't, meaning restrictive umasks like 0027 or 0111 produce wrong ancestor modes beyond just the test failure you caught. Filed that as #12714 and opened #12715 to fix both the implementation and replace the probe-based assertions with the correct assert_eq!(0o40_755) checks. Hopefully useful context!
Excellent work, I'll close this issue and the related PR then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11363