Skip to content

tee: add splice() and tee() zero-copy fast-path#11943

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:tee-splice-m
Open

tee: add splice() and tee() zero-copy fast-path#11943
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:tee-splice-m

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Apr 22, 2026

Closes #11466 .

> tee </tmp/huge |pv >/dev/null
^C58GiB 0:00:01 [2.58GiB/s] 
> tee-splice </tmp/huge |pv >/dev/null
^C.6GiB 0:00:02 [38.4GiB/s]

@oech3 oech3 force-pushed the tee-splice-m branch 3 times, most recently from cfb3c51 to 8db29e1 Compare April 22, 2026 13:14
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 22, 2026

Merging this PR will improve performance by 6.42%

⚡ 1 improved benchmark
✅ 322 untouched benchmarks
⏩ 46 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation tee_stdin_file[10000000] 179.7 µs 168.8 µs +6.42%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing oech3:tee-splice-m (9bb5588) with main (0011d54)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/expand/bounded-memory is now being skipped but was previously passing.
Congrats! The gnu test tests/printf/printf-surprise is now passing!

@oech3 oech3 marked this pull request as ready for review April 22, 2026 14:44
@oech3

This comment was marked as resolved.

Comment thread src/uu/tee/src/tee.rs Outdated
@oech3

This comment was marked as off-topic.

@oech3 oech3 force-pushed the tee-splice-m branch 5 times, most recently from 772a3ad to 795c27c Compare April 28, 2026 09:43
@oech3 oech3 force-pushed the tee-splice-m branch 5 times, most recently from ceba8b4 to f66fbd1 Compare April 29, 2026 17:49
@oech3

This comment was marked as outdated.

@oech3 oech3 force-pushed the tee-splice-m branch 2 times, most recently from 96fdadd to 71918b9 Compare May 1, 2026 03:40
@oech3 oech3 marked this pull request as draft May 26, 2026 11:38
@oech3 oech3 marked this pull request as ready for review May 26, 2026 11:44
@oech3

This comment was marked as resolved.

@oech3 oech3 force-pushed the tee-splice-m branch 8 times, most recently from 51a8fa9 to df12df1 Compare May 27, 2026 14:36
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 27, 2026

@sylvestre @cakebaker Would you review this?

@oech3 oech3 force-pushed the tee-splice-m branch 5 times, most recently from d8fe56e to e1744b8 Compare May 29, 2026 09:31
@oech3 oech3 force-pushed the tee-splice-m branch 6 times, most recently from 9608b1e to 1734a9c Compare June 2, 2026 11:15
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Jun 2, 2026

@sylvestre Would you review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tee: use splice and tee syscalls for performance

2 participants