Resolve device cloud-key locators - #30
Merged
Merged
Conversation
Allow authenticated ingress to select a device directly by its non-secret device key and public cloud key while retaining bounded ambiguity rejection.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for resolving devices using the
(device key, cloud key)pair without requiring organisation, project, or legacy owner scope information.This improves lookup flexibility for flows where the cloud key is already available and acts as a strong secondary identifier. By matching on both
properties.DeviceKeyandanalytics.cloudpublickey, the resolver can uniquely identify devices in a more direct and reliable way.The change also preserves the existing fail-closed behaviour by rejecting duplicate matches for the same locator pair, preventing ambiguous device resolution and reducing the risk of resolving the wrong device.
New tests cover: